Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow if and input in group steps #56

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

Tyler-2
Copy link
Contributor

@Tyler-2 Tyler-2 commented Jun 14, 2023

Fixes #54 and #57

I have no idea how to get this approved and merged because there is no contribution documentation.

In the meantime... you can save:
https://raw.githubusercontent.com/Tyler-2/pipeline-schema/fix-if-and-input/schema.json
to a local place and then open up your VSCode or VSCodium settings and navigate to Settings, Extensions, YAML, Yaml: Schemas, "Edit in settings.json".

And then add something like:

    "yaml.schemas": {
        
        "/home/someuser/unnecessarydownloads/schema.json": "pipeline.yml"

    },

Which will tell the yaml language server to use that schema.json for files named pipeline.yml.

@Techn1x
Copy link

Techn1x commented Jun 19, 2023

@jonathanly @alexle @sj26
Apologies for the ping-spray, hoping one of you (being the most recent contributors) can help us out

@eleanorakh eleanorakh requested a review from l-suzuki June 21, 2023 05:08
@eleanorakh
Copy link
Contributor

Thanks @Tyler-2, we'll take a look at this one shortly 👀

@angusfretwell angusfretwell self-requested a review June 28, 2023 02:38
@angusfretwell
Copy link
Contributor

Hi @Tyler-2, thanks for this! I've just added some examples to our tests for group steps and also included stringInputStep in the steps schema.

@angusfretwell angusfretwell merged commit 7db1bf3 into buildkite:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group is missing if
4 participants