Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mixin-deep from 1.3.1 to 1.3.2 #1367

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@dependabot @github
Copy link
Contributor

commented on behalf of github Aug 28, 2019

Bumps mixin-deep from 1.3.1 to 1.3.2.

Commits
Maintainer changes

This version was pushed to npm by doowb, a new releaser for mixin-deep since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies label Aug 28, 2019
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)
- [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mixin-deep-1.3.2 branch from d795b84 to cf6ab89 Sep 16, 2019
@mergify mergify bot merged commit 70ae7c1 into master Sep 16, 2019
2 checks passed
2 checks passed
Summary 1 rule matches
Details
concourse-ci/concourse Concourse CI build success
Details
@nemobot

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/mixin-deep-1.3.2 branch Sep 16, 2019
@iagobruno

This comment has been minimized.

Copy link

commented Sep 16, 2019

image

@euojeff

This comment has been minimized.

Copy link

commented Sep 18, 2019

👀

@Beyarz

This comment has been minimized.

Copy link

commented Sep 18, 2019

👁️👁️

@ahungry

This comment has been minimized.

Copy link

commented Sep 18, 2019

The package going from 1.3.1 to 1.3.2 alters behavior and changes the output of this test from passing to failing:

           it('should do a deep merge', function () {
             var obj1 = { a: { prototype: { a: 1 }, b: 1, c: 1, d: { e: 1, f: 1 } } };
             var obj2 = { a: { prototype: { b: 1 }, b: 2, d: { f: 'f' } } };

             mixinDeep(obj1, obj2).should.eql({ a: { prototype: { a: 1, b: 1 }, b: 2, c: 1, d: { e: 1, f: 'f' } } });
           });

I don't think package dependencies should auto-upgrade when the dependency can't be relied on to follow semver correctly.

@gabro

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

@ahungry fair point, although that’s why we have tests. If our tests can’t observe any visible changes, then we’re fine with bumping the dep

@ademidun

This comment has been minimized.

Copy link

commented Sep 19, 2019

For context: @gabro's tweet explains this PR very well:

https://twitter.com/gabro27/status/1173547934132178944

Made me eat my words 😂
https://twitter.com/tomiwa1a/status/1174678002845794304

2gnpvc

@prometheus1337

This comment has been minimized.

Copy link

commented Sep 20, 2019

beep

@nawaphonOHM

This comment has been minimized.

Copy link

commented Sep 23, 2019

Hello world

@mwenghi

This comment has been minimized.

Copy link

commented Sep 25, 2019

@dependabot cancel merge

@dependabot @github

This comment has been minimized.

Copy link
Contributor Author

commented on behalf of github Sep 25, 2019

Sorry, only users with push access can use that command.

@mwenghi

This comment has been minimized.

Copy link

commented Sep 25, 2019

@dependabot reopen

@dependabot @github

This comment has been minimized.

Copy link
Contributor Author

commented on behalf of github Sep 25, 2019

Sorry, only users with push access can use that command.

@stefanomezza

This comment has been minimized.

Copy link

commented Sep 25, 2019

@dependabot this sentence is false

@bhatvikrant

This comment has been minimized.

Copy link

commented Sep 25, 2019

image

@yogo1212

This comment has been minimized.

Copy link

commented Sep 25, 2019

if you ignore the entertainment value, this PR is very carbon ineffective.
turn off the bot, don't automate pollution - i say

@buildo buildo locked as spam and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
You can’t perform that action at this time.