Bump mixin-deep from 1.3.1 to 1.3.2 #1367
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/mixin-deep-1.3.2
branch
from
d795b84
to
cf6ab89
Compare
|
|
|
|
|
👀 |
|
👁️👁️ |
|
The package going from 1.3.1 to 1.3.2 alters behavior and changes the output of this test from passing to failing: it('should do a deep merge', function () {
var obj1 = { a: { prototype: { a: 1 }, b: 1, c: 1, d: { e: 1, f: 1 } } };
var obj2 = { a: { prototype: { b: 1 }, b: 2, d: { f: 'f' } } };
mixinDeep(obj1, obj2).should.eql({ a: { prototype: { a: 1, b: 1 }, b: 2, c: 1, d: { e: 1, f: 'f' } } });
});I don't think package dependencies should auto-upgrade when the dependency can't be relied on to follow semver correctly. |
|
@ahungry fair point, although that’s why we have tests. If our tests can’t observe any visible changes, then we’re fine with bumping the dep |
|
For context: @gabro's tweet explains this PR very well: https://twitter.com/gabro27/status/1173547934132178944 Made me eat my words 😂
|
|
beep |
|
Hello world |
|
@dependabot cancel merge |
|
Sorry, only users with push access can use that command. |
|
@dependabot reopen |
|
Sorry, only users with push access can use that command. |
|
@dependabot this sentence is false |
|
|
|
if you ignore the entertainment value, this PR is very carbon ineffective. |
Bumps mixin-deep from 1.3.1 to 1.3.2.
Commits
754f0c21.3.290ee1faensure keys are valid when mixing in valuesMaintainer changes
This version was pushed to npm by doowb, a new releaser for mixin-deep since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot ignore this [patch|minor|major] versionwill close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.