Removed IncompatibleVersionError leads to ImportError in buildout-versions #38

Closed
reinout opened this Issue Dec 29, 2012 · 6 comments

Projects

None yet

5 participants

@reinout
Contributor
reinout commented Dec 29, 2012

I use buildout-versions to report versions that buildout pins. With buildout 2.0a5, this extension no longer works because of an import error:

from zc.buildout.easy_install import IncompatibleVersionError

The line in buildout-versions where it fails: https://github.com/Simplistix/buildout-versions/blob/master/src/buildout_versions/__init__.py#L12

In zc.buildout.easy_install, there is a IncompatibleConstraintError.

  • Should the old name be re-added in buildout? Perhaps as a BBB alias?
  • Or should it be fixed (try/except import, probably) in buildout-versions?

(I think the first option is the best on first sight).

Contributor
reinout commented Dec 29, 2012

I also did a quick test with the old buildout.dumppickedversions extension. That one failed in a different way:

$ bin/buildout 
While:
  Installing.
  Checking for upgrades.

An internal error occured due to a bug in either zc.buildout or in a
recipe being used:
Traceback (most recent call last):
  File "/Users/reinout/Dotfiles/buildout/eggs/zc.buildout-2.0.0a5-py2.7.egg/zc/buildout/buildout.py", line 1744, in main
    getattr(buildout, command)(args)
  File "/Users/reinout/Dotfiles/buildout/eggs/zc.buildout-2.0.0a5-py2.7.egg/zc/buildout/buildout.py", line 432, in install
    self._maybe_upgrade()
  File "/Users/reinout/Dotfiles/buildout/eggs/zc.buildout-2.0.0a5-py2.7.egg/zc/buildout/buildout.py", line 877, in _maybe_upgrade
    allow_hosts = self._allow_hosts
  File "/Users/reinout/Dotfiles/buildout/eggs/zc.buildout-2.0.0a5-py2.7.egg/zc/buildout/easy_install.py", line 729, in install
    return installer.install(specs, working_set)
  File "/Users/reinout/Dotfiles/buildout/eggs/zc.buildout-2.0.0a5-py2.7.egg/zc/buildout/easy_install.py", line 572, in install
    for dist in self._get_dist(requirement, ws):
TypeError: get_dist() takes exactly 4 arguments (3 given)
*************** PICKED VERSIONS ****************
[versions]

*************** /PICKED VERSIONS ***************

I'd rather use buildout-versions, so this error doesn't bother me :-)

Member
mgedmin commented Dec 30, 2012

Perhaps the functionality of buildout-versions should be included as standard upstream buildout features?

Contributor

+1

Owner

This particular bug is fixed.

@jimfulton jimfulton closed this Jan 13, 2013
petri commented Jan 17, 2013

I just cloned master, and both of the above errors reported by Reinout are still there... am I missing something? Or has the fix just not yet been pushed here?

Also, a buildout recipe I've helped maintain (https://github.com/koodaamo/cns.recipe.symlink) fails the same way as buildout.dumppickedversions (as reported by Reinout above). Perhaps it's worth opening a new ticket for that?

Owner

I thought I'd fixed the first problem. I pushed a fix to master.

The second problem isn't a buildout problem. I'm not going to worry about problems caused by extensions monkey-patching internal implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment