distutils scripts -- correct order of operations #134

Merged
merged 2 commits into from Jul 12, 2013

Conversation

Projects
None yet
3 participants
Contributor

AaronAsAChimp commented Jul 8, 2013

So 'from ... import' lines are correctly recognized. The following example from pylint was not being correctly parsed:

#![...]/bin/python
from pylint import run_pylint
run_pylint()
Owner

jimfulton commented Jul 8, 2013

Thanks for the PR!

Someone will need to write a test before this can be merged.

Contributor

reinout commented Jul 12, 2013

The fix (for my original mistake :-) ) looks good.

I've pulled the branch into my clone so that travis can check it.
https://travis-ci.org/reinout/buildout/builds/8999768
3 out of 4 are OK. The python 3.2 one isn't, but that looks like an unrelated anomaly (a number of logging handlers that is 1 off or so).

I'm seeing the same problem with docutils' scripts, so the fix is very welcome.

@jimfulton jimfulton added a commit that referenced this pull request Jul 12, 2013

@jimfulton jimfulton Merge pull request #134 from AaronAsAChimp/distutils-from
distutils scripts -- correct order of operations
7dc7b39

@jimfulton jimfulton merged commit 7dc7b39 into buildout:master Jul 12, 2013

@tseaver tseaver added a commit that referenced this pull request Sep 5, 2013

@tseaver tseaver Changelog entry for #134 fix. 2d44d7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment