Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error when --path is invalid #161

Merged
merged 1 commit into from Apr 15, 2019
Merged

Conversation

jromero
Copy link
Member

@jromero jromero commented Apr 12, 2019

Resolves #122

Signed-off-by: Javier Romero j.romero.1214@gmail.com

Output:
image

image

build.go Outdated Show resolved Hide resolved
run.go Outdated Show resolved Hide resolved
@ekcasey
Copy link
Member

ekcasey commented Apr 12, 2019

@jromero Thanks for the contribution!

So far, we have intentionally avoided abstracting the filesystem, instead creating tmp dirs or using test fixtures when necessary for testing. I would like to stick to that pattern if possible.

@jromero
Copy link
Member Author

jromero commented Apr 13, 2019

@jromero Thanks for the contribution!

So far, we have intentionally avoided abstracting the filesystem, instead creating tmp dirs or using test fixtures when necessary for testing. I would like to stick to that pattern if possible.

Good to know. Made the necessary changes using fixtures.

Signed-off-by: Javier Romero <j.romero.1214@gmail.com>
@ekcasey ekcasey merged commit cb45dab into buildpacks:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error when --path is invalid
2 participants