feat: install latest hugo according to platform #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshita-Kanal <harshita.kgv@gmail.com>
jromero
requested changes
Sep 15, 2021
| cd tools; mkdir bin; cd bin; curl -L -O $(shell curl https://api.github.com/repos/gohugoio/hugo/releases/latest | jq -r '.assets[30].browser_download_url') | ||
|
|
||
| else | ||
| @echo $(shell uname -s) |
There was a problem hiding this comment.
Taken from https://stackoverflow.com/a/12099167/552902
Something like this should work.
UNAME_S := $(shell uname -s)
ifeq ($(UNAME_S),Darwin)
// macOS
else
// assumed linux
endif
|
@Harshita-Kanal 👈 (poke) Is this something you are still interested in resolving. It looks to be so close to being done. |
Yes just missed it, sorry for the delay! |
Signed-off-by: Harshita-Kanal <harshita.kgv@gmail.com>
Harshita-Kanal
force-pushed
the
install-hugo
branch
from
231410a
to
b3a0ddd
Compare
Signed-off-by: Harshita-Kanal <harshita.kgv@gmail.com>
|
Was able to get it to work for Linux I think. How should we handle the case for Windows? |
jromero
added a commit
that referenced
this pull request
Oct 25, 2021
Merged
jromero
added a commit
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The approach here uses the GitHub API to fetch the
browser_download_urlwhich is obtained by parsing the JSON response. For windows, this gets the latest zip file of Hugo extended for windows OS. However, the implementation for Mac, Linux is a work in progress.Related
Fixes #395
Signed-off-by: Harshita-Kanal harshita.kgv@gmail.com