diff --git a/0000-template.md b/0000-template.md index 2d56066b6..eca6e6349 100644 --- a/0000-template.md +++ b/0000-template.md @@ -3,8 +3,7 @@ - Name: (fill in the feature name: My Feature) - Start Date: (fill in today's date: YYYY-MM-DD) - Author(s): (Github usernames) - -- Status: Draft +- Status: Draft - RFC Pull Request: (leave blank) - CNB Pull Request: (leave blank) - CNB Issue: (leave blank) diff --git a/merge-rfc.sh b/merge-rfc.sh index f736d56a1..375d45413 100755 --- a/merge-rfc.sh +++ b/merge-rfc.sh @@ -75,7 +75,7 @@ TARGET=${SOURCE//0000/$(printf "%04d" "${ID}")} sed -i '' "s|- RFC Pull Request:.*|- RFC Pull Request: [rfcs#${PR}](https://github.com/buildpacks/rfcs/pull/${PR})|" "${SOURCE}" sed -i '' "s|- CNB Issue:.*|- CNB Issue: $issues|" "${SOURCE}" -sed -i '' "s,- Status:.*,- Status: **Approved** | On Hold," "${SOURCE}" +sed -i '' "s|- Status:.*|- Status: Approved|" "${SOURCE}" git mv "${SOURCE}" "${TARGET}" git add "${TARGET}" git commit --signoff --message "RFC ${ID} diff --git a/text/0000-add-status-field.md b/text/0000-add-status-field.md index f38ca2a30..5c1d4ff9e 100644 --- a/text/0000-add-status-field.md +++ b/text/0000-add-status-field.md @@ -3,7 +3,7 @@ - Name: Add Status to RFC Metadata - Start Date: 2021-07-14 - Author(s): @aemengo, @ekcasey -- Status: Approved | On Hold +- Status: Draft - RFC Pull Request: (leave blank) - CNB Pull Request: (leave blank) - CNB Issue: (leave blank) @@ -30,10 +30,11 @@ This RFC formally introduces the **"On Hold"** status for an RFC, in a way that' A new `Status:` field in the `Meta` section of the RFC template. See [#meta](#meta) for example. The acceptable values are distinguished in the following ways: +- **Draft**: The Core team has not yet approved the RFC. Edits are still being made. - **Approved**: The Core team has approved the RFC and is accepting PRs for its implementation. - **On Hold**: The Core team has approved the RFC, but PRs are currently not being accepted for its implementation. A reason must be provided in the RFC. -The `Status:` field does not intend to reflect states that are already implied by the RFC process. Examples including: *Draft*, *In Review*, *Closed*, etc. +The `Status:` field does not intend to reflect states that are already implied by the RFC process. Examples including: *In Review*, *Closed*, etc. # How it Works [how-it-works]: #how-it-works @@ -41,19 +42,19 @@ The `Status:` field does not intend to reflect states that are already implied b We will add the following to the RFC `Meta` section template: ``` -- Status: Approved | On Hold +- Status: Draft ``` When an RFC is approved, the [../merge-rfc.sh](../merge-rfc.sh) script reflects the change like so: ``` -- Status: **Approved** | On Hold +- Status: Approved ``` When an RFC is put on hold (_via Pull Request_) then change is reflected like so: ``` -- Status: Approved | **On Hold** +- Status: On Hold ``` # Drawbacks