Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for donating kpack to CNB #235

Merged
merged 32 commits into from
Jul 6, 2023

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Oct 12, 2022

Readable

Signed-off-by: Juan Bustamante jbustamante@vmware.com

@buildpack-bot
Copy link
Member

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante force-pushed the jjbustamante/feature/kpack-donation branch from 1a6b53d to 04db152 Compare October 12, 2022 20:57
@jjbustamante jjbustamante changed the title Proposal for the donation of the kpack to CNB Proposal for donate kpack to CNB Oct 12, 2022
@samj1912 samj1912 self-assigned this Oct 12, 2022
@samj1912 samj1912 changed the title Proposal for donate kpack to CNB Proposal for donating kpack to CNB Oct 12, 2022
@jjbustamante
Copy link
Member Author

jjbustamante commented Oct 18, 2022

Some feedback from the Working Group meeting last week (10/13)

  • Add a section to describe how do we propose to handle the slack channel migration
  • Describe how to handle trademarks and wordmarks from logos and stuff like that
  • Add in the governance section how the RFC process (kpack has their own process) is going to be handle

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@natalieparellano
Copy link
Member

Is there a reason this is still in draft? Can we un-draft it?

@jjbustamante
Copy link
Member Author

Is there a reason this is still in draft? Can we un-draft it?

Not 100% sure, but I think we will do it after merging the maintainer component role RFC

Copy link
Member

@hone hone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for taking so long for reviewing this RFC. From the TOC doc from @samj1912 and overall discussion, I believe the RFC is proposing the donation of kpack into "buildpacks-community" as a staging ground with plans to move into "buildpacks".

Here are the open items I've identified that should be merged in before migrating to the Buildpacks Community Organization (Phase 1):

In the TOC doc, governance is marked as a phase 2 item, but a clear governance structure will help with some of the Phase 2 items so I'd advocate for an interim one in phase 1.

Here are my key times before migrating to the Buildpacks Organization (Phase 2):

While not part of the required list, I'd love to see:

text/0000-kpack-donation-to-cnb.md Outdated Show resolved Hide resolved
Co-authored-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
@jjbustamante
Copy link
Member Author

Thanks for the feedback @hone, I just created a PR for the RELEASE.md file

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@hone
Copy link
Member

hone commented May 18, 2023

The three unknown licenses from go-license are all compatible from checking by hand:

project license
github.com/alibabacloud-go/cr-20160607/client Apache 2.0
github.com/alibabacloud-go/tea-xml/service Apache 2.0
github.com/matthewmcnew/archtest MIT

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@hone hone dismissed jkutner’s stale review June 1, 2023 17:16

Needs to re-review given the changes. :)

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante
Copy link
Member Author

Update
Yesterday the Governance.md was merged, I think we are ready again to review the requirements for the donation Phase 1

cc @samj1912 @hone @jkutner @tomkennedy513 @matthewmcnew

@jjbustamante jjbustamante requested a review from hone June 22, 2023 13:06
@natalieparellano
Copy link
Member

Should we move this into status/voting?

@hone
Copy link
Member

hone commented Jun 29, 2023

Thanks for all the work @jjbustamante and the rest of the kpack team has put in this. For the governance, does kpack have a notion of contributors or just maintainers?

@hone
Copy link
Member

hone commented Jun 29, 2023

Moving this to voting with a close a week from today of July 6.

@jjbustamante
Copy link
Member Author

Thanks for all the work @jjbustamante and the rest of the kpack team has put in this. For the governance, does kpack have a notion of contributors or just maintainers?

We do have contributors but I missed specifying them. I will update the project, because it is important to define the contributor role.

Just for help others: I took the original governance template document from CNCF, but there is another one I can use to define the contributor role.

Thanks Terrence!!!

natalieparellano added a commit that referenced this pull request Jul 6, 2023
[#235]

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano merged commit e3d8367 into main Jul 6, 2023
7 checks passed
@natalieparellano natalieparellano deleted the jjbustamante/feature/kpack-donation branch July 6, 2023 14:29
dvaumoron pushed a commit to dvaumoron/CNB-rfcs that referenced this pull request Sep 14, 2023
[buildpacks#235]

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet