Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribution Specs (v3) - Lifecycle Distribution Spec #264

Merged
merged 9 commits into from Nov 17, 2021
Merged

Distribution Specs (v3) - Lifecycle Distribution Spec #264

merged 9 commits into from Nov 17, 2021

Conversation

jimil749
Copy link
Contributor

This PR consists the artifact format and the delivery mechanism for Buildpacks' Lifecycle.

Signed-off-by: Jimil Desai jimildesai42@gmail.com

@jimil749 jimil749 requested a review from a team as a code owner October 26, 2021 17:42
jromero
jromero requested changes Oct 27, 2021
View reviewed changes
distribution.md Outdated Show resolved Hide resolved
distribution.md Outdated Show resolved Hide resolved
distribution.md Show resolved Hide resolved
@jimil749 jimil749 force-pushed the lifecycle-distribution branch 3 times, most recently from c9311f7 to a4b82b4 Compare October 27, 2021 16:03
@jimil749
Copy link
Contributor Author

jimil749 commented Oct 27, 2021 •
edited

@jromero sorry for the mess above, but I accidently committed your suggested changes via github UI and now the DCO fails because of unsigned commit. Not sure how to proceed. (Tried to using amend and force pushing but still won't work)

@hone
Copy link
Member

hone commented Oct 27, 2021

I was just searching the platform spec and I don't think we even talk about lifecycle.toml (Lifecycle Descriptor). Is that part of distributing the lifecycle?

@jromero
Copy link
Member

jromero commented Oct 27, 2021

@jromero sorry for the mess above, but I accidently committed your suggested changes via github UI and now the DCO fails because of unsigned commit. Not sure how to proceed. (Tried to using amend and force pushing but still won't work)

It happens. I wouldn't worry about it. It is my understanding that we can bypass DCO for none-code contributions. Tip for the future: You can manually add the following text to the suggestion acceptance commits:

Signed-off-by: YOUR_NAME <YOUR_EMAIL>

@jromero
Copy link
Member

jromero commented Oct 27, 2021

I was just searching the platform spec and I don't think we even talk about lifecycle.toml (Lifecycle Descriptor). Is that part of distributing the lifecycle?

That feels like a gaping hole. We should add it. pack definitely uses it to determine compatibility.

@jimil749 could we include lifecycle.toml as defined here. It should be located at /cnb/lifecycle/.

natalieparellano
natalieparellano reviewed Oct 27, 2021
View reviewed changes
distribution.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano reviewed Oct 27, 2021
View reviewed changes
distribution.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano reviewed Oct 27, 2021
View reviewed changes
distribution.md Outdated Show resolved Hide resolved
@natalieparellano
Copy link
Member

lifecycle.toml is included when the lifecycle is distributed as a tarball (i.e., GitHub release). When the lifecycle is distributed as an image, its contents are serialized in the labels described already.

@jimil749
Copy link
Contributor Author

I was just searching the platform spec and I don't think we even talk about lifecycle.toml (Lifecycle Descriptor). Is that part of distributing the lifecycle?

That feels like a gaping hole. We should add it. pack definitely uses it to determine compatibility.

@jimil749 could we include lifecycle.toml as defined here. It should be located at /cnb/lifecycle/.

Yep, I'll have to go over the RFC once

@jimil749 jimil749 requested a review from jromero October 28, 2021 17:59
jromero
jromero requested changes Oct 29, 2021
View reviewed changes
distribution.md Show resolved Hide resolved
distribution.md Outdated Show resolved Hide resolved
jromero
jromero approved these changes Nov 3, 2021
View reviewed changes
distribution.md Outdated Show resolved Hide resolved
distribution.md Outdated Show resolved Hide resolved
@hone hone requested review from nebhale and jkutner November 3, 2021 18:14
@hone hone requested review from nebhale and sclevine November 3, 2021 18:14
jimil749 and others added 2 commits November 4, 2021 14:10
@jimil749
feat: lifecycle distribution spec
e2a913b 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749 @jromero
Update distribution.md
35cdaee 
Co-authored-by: Javier Romero <root@jromero.codes>
jimil749 and others added 5 commits November 4, 2021 14:10
@jimil749 @jromero
Update distribution.md
7255cb6 
Co-authored-by: Javier Romero <root@jromero.codes>
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
fix: typo and update label description
7df5df9 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
feat: add supported and deprecated def and lifecycle distribution format
966c516 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
fix: indentation of supported and deprecated bullet point
b609cde 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
fix: indentation
b2266e3 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
resolve merge conflict
4a13b0d 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jromero
Copy link
Member

jromero commented Nov 4, 2021

@jkutner, this one is waiting on you. 🙏

natalieparellano
natalieparellano reviewed Nov 4, 2021
View reviewed changes
distribution.md Outdated Show resolved Hide resolved
@jimil749
update lifecycle definition
cd60743 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
Copy link
Contributor Author

Is this good to merge?

@jkutner jkutner merged commit d3395b2 into buildpacks:distribution/0.3 Nov 17, 2021
@jimil749 jimil749 mentioned this pull request Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkutner jkutner jkutner approved these changes

@hone hone hone approved these changes

@nebhale nebhale nebhale approved these changes

@jromero jromero jromero approved these changes

@sclevine sclevine sclevine approved these changes

@natalieparellano natalieparellano natalieparellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jimil749 @hone @jromero @natalieparellano @jkutner @nebhale @sclevine