Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board/pc/post-build.sh: #121

Closed
wants to merge 4 commits into from

Conversation

AndreiCherniaev
Copy link

Allow to use grub config file with set timeout not default. Before this set timeout always was 5s and can't be changed, any set timeout from BR2_TARGET_GRUB2_BUILTIN_CONFIG_PC was ignored

Allow to use grub config file with set timeout not default. Before this set timeout always was 5s and can't be changed, any set timeout from BR2_TARGET_GRUB2_BUILTIN_CONFIG_PC was ignored
Also we need delete configuration from files because now this configuration is made by human script or post-build.sh
@AndreiCherniaev
Copy link
Author

AndreiCherniaev commented Jan 11, 2023

looks like I need create two ways inside if [ -d "$BINARIES_DIR/efi-part/" ]; then

  1. for bios change "$TARGET_DIR/boot/grub/grub.cfg"
  2. for efi change "$BINARIES_DIR/efi-part/EFI/BOOT/grub.cfg"

because now if user set GRUB2_BUILTIN_CONFIG_EFI I still works with "$TARGET_DIR/boot/grub/grub.cfg" only...

And also what is BR2_PACKAGE_GNU_EFI_ARCH_SUPPORTS ?

Thanks Евгений Исаев

@tpetazzoni
Copy link
Member

As explained at https://github.com/buildroot/buildroot, we do not take pull requests on the Github project, we need contributions to be submitted over e-mail to the mailing list. See https://buildroot.org/downloads/manual/manual.html#submitting-patches for our contribution guidelines. Thanks!

@tpetazzoni tpetazzoni closed this Jan 28, 2023
@AndreiCherniaev
Copy link
Author

AndreiCherniaev commented Jan 29, 2023

we do not take pull requests on the Github

  1. I still waiting response about my commit "board/pc/post-build.sh: allow to use grub config file". Did you got it via email?
  2. Buildroot use very unuserfriendly way for discussion without gerrit or github... I suggest allow github commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants