Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thomas folbrecht #5

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tfolbrecht
Copy link
Contributor

tfolbrecht commented Mar 11, 2019

No description provided.

macjabeth and others added some commits Mar 11, 2019

initial project setup & routing
Co-authored-by: Thomas Folbrecht tfolbrecht@gmail.com
setup reducers skeleton
Co-authored-by: Thomas Folbrecht tfolbrecht@gmail.com
setup actions & middleware
Co-authored-by: Thomas Folbrecht tfolbrecht@gmail.com
create base paths & registration components
Co-authored-by: Thomas Folbrecht tfolbrecht@gmail.com
Merge pull request #2 from buildweek-howto/jonathan-picazo
create base components & authentication handling
squash the import bugs
Co-authored-by: Thomas Folbrecht tfolbrecht@gmail.com

@tfolbrecht tfolbrecht requested a review from macjabeth Mar 11, 2019

@@ -0,0 +1,98 @@
import React from 'react';

This comment has been minimized.

@macjabeth

macjabeth Mar 12, 2019

Contributor

This entire file can be deleted as it's no longer in use.

const [password, setPassword, updatePassword] = useInput();
const [firstName, setFirstName, updateFirstName] = useInput();
const [lastName, setLastName, updateLastName] = useInput();

This comment has been minimized.

@macjabeth

macjabeth Mar 12, 2019

Contributor

These here, the firstname and lastname variables need to be camel-cased wherever they're in use.

setEmail(''); setUsername(''); setPassword('');
setFirstname(''); setLastname('');
};

This comment has been minimized.

@macjabeth

macjabeth Mar 12, 2019

Contributor

So these here need to be changed so they match the casing.

firstname={firstname} updateFirstname={updateFirstname}
lastname={lastname} updateLastname={updateLastname}
/>
);

This comment has been minimized.

@macjabeth

macjabeth Mar 12, 2019

Contributor

And these here need to match the casing.

lastname, updateLastname,
handleSubmit
} = props;

This comment has been minimized.

@macjabeth

macjabeth Mar 12, 2019

Contributor

These here, and the input form values below.

@macjabeth
Copy link
Contributor

macjabeth left a comment

So I left a few comments on what needs to be updated here. Once it's looking all pucker your end, you can commit the changes and push to your repo again. 😺

@macjabeth macjabeth closed this Mar 12, 2019

@tfolbrecht tfolbrecht reopened this Mar 12, 2019

@tfolbrecht tfolbrecht closed this Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.