Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Kotlin Gradle plugin version and Type mismatch error #69

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

ryanhz
Copy link
Contributor

@ryanhz ryanhz commented Nov 13, 2018

This PR will fix issue #68
and issue #67

Full error message:

e: /Users/Ryan/Applications/flutter/.pub-cache/git/flutter_plugins-64d1715944b2f9b0d08cedfba158cac6d2dccc77/device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/DeviceCalendarPlugin.kt: (82, 50): Type mismatch: inferred type is String? but String was expected
e: /Users/Ryan/Applications/flutter/.pub-cache/git/flutter_plugins-64d1715944b2f9b0d08cedfba158cac6d2dccc77/device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/DeviceCalendarPlugin.kt: (92, 35): Type mismatch: inferred type is String? but String was expected
e: /Users/Ryan/Applications/flutter/.pub-cache/git/flutter_plugins-64d1715944b2f9b0d08cedfba158cac6d2dccc77/device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/DeviceCalendarPlugin.kt: (96, 31): Type mismatch: inferred type is Long? but Long was expected
e: /Users/Ryan/Applications/flutter/.pub-cache/git/flutter_plugins-64d1715944b2f9b0d08cedfba158cac6d2dccc77/device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/DeviceCalendarPlugin.kt: (97, 29): Type mismatch: inferred type is Long? but Long was expected
e: /Users/Ryan/Applications/flutter/.pub-cache/git/flutter_plugins-64d1715944b2f9b0d08cedfba158cac6d2dccc77/device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/DeviceCalendarPlugin.kt: (99, 55): Type mismatch: inferred type is String? but String was expected
e: /Users/Ryan/Applications/flutter/.pub-cache/git/flutter_plugins-64d1715944b2f9b0d08cedfba158cac6d2dccc77/device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/DeviceCalendarPlugin.kt: (105, 47): Type mismatch: inferred type is String? but String was expected
e: /Users/Ryan/Applications/flutter/.pub-cache/git/flutter_plugins-64d1715944b2f9b0d08cedfba158cac6d2dccc77/device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/DeviceCalendarPlugin.kt: (105, 59): Type mismatch: inferred type is String? but String was expected
@MaikuB
Copy link
Contributor

MaikuB commented Nov 13, 2018

lgtm

Copy link

@igolubic igolubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Passing now.

Copy link

@linuxeasy linuxeasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with changes in the PR, and compilations successful. Executions also succeeded!

@codeXLinkX
Copy link

codeXLinkX commented Nov 16, 2018

This issue is still open, does it mean the package hasn't been updated yet? It still shows the version as 0.0.6.

@MaikuB MaikuB merged commit 97c7776 into builttoroam:develop Nov 16, 2018
@codeXLinkX
Copy link

Thanks for merging it. When is it going to take effect? Should I wait for 0.0.7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants