New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create list wrapper class for "/options/" calls #207

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@kvnfrederiksen

kvnfrederiksen commented Mar 7, 2018

Options responses are not structured in uniform with the rest of the API. All others return with count and total, along with data. Since responses for options calls do not distinguish these variables, I created a new class that does not extend StandardListWrapper.

Additionally, Option objects are returned as a data array, thus it is parsed as an "Option[]" array first, and then convert to a List.

Create list wrapper class for "/options/" calls
Options responses are not structured in uniform with the rest of the API. All others return with count and total, along with data. Since responses for options calls do not distinguish these variables, I created a new class that does not extend StandardListWrapper.

Additionally, Option objects are returned as a data array, thus it is parsed as an "Option[]" array first, and then convert to a List.
@coveralls

This comment has been minimized.

coveralls commented Mar 7, 2018

Coverage Status

Coverage remained the same at 66.366% when pulling 3784085 on kvnfrederiksen-patch-1 into 3b57163 on master.

kvnfrederiksen added some commits Mar 7, 2018

Create list wrapper class for "/options/" calls
Options responses are not structured in uniform with the rest of the API. All others return with count and total, along with data. Since responses for options calls do not distinguish these variables, I created a new class that does not extend StandardListWrapper.

Additionally, Option objects are returned as a data array, thus it is parsed as an "Option[]" array first, and then convert to a List.

I also added Param classes, methods into StandardBullhornData, RestUrlFactory, and RestUriVariablesFactory to handle these calls, along with beginning some unit testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment