Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to select OpenSSL engine #36

Merged
merged 7 commits into from Oct 12, 2011
Merged

Conversation

@vincentbernat
Copy link
Contributor

vincentbernat commented Oct 3, 2011

Hi!

With this patch, the OpenSSL engine can be selected. For example, this allows to select "aesni" on platform where it is not used by default.

It is stacked on top of two of my previous patches because I want to update the manual page but there is no strong dependency. We can just keep the last commit.

@bpineau

This comment has been minimized.

Copy link

bpineau commented on 0fe6403 Oct 4, 2011

Hi Vincent,
I did the same (here bpineau@7749f2e ),
but I prefer your version (logging the actually loaded engine or the openssl error stack is useful).

I confirm this works well (I run a stud with the exact same ENGINE_load_builtin_engines() , ENGINE_by_id(foo), ENGINE_init(e), ENGINE_set_default(), ENGINE_finish(), ENGINE_free() sequence in production for about two weeks, with intel-accel engine).

@jamwt jamwt merged commit 0fe6403 into bumptech:master Oct 12, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.