New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put in ringbuffer data that could be sent directly. #37

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@vincentbernat
Contributor

vincentbernat commented Oct 4, 2011

Here is some micro optimization. I have written it in hope to decrease latency but this does not work. However, it increases performances by about 6% on my benchmarks. Maybe this is not worth introducing such optimizations (and I am not sure this is correct, for example SSL_write could trigger a new handshake and in this case, I hope that the next SSL_write will still trigger it).

Don't put in ringbuffer data that could be sent directly.
This is a micro optimization designed to decrease latency.
@jamwt

This comment has been minimized.

Show comment
Hide comment
@jamwt

jamwt Oct 12, 2011

Member

I'd prefer to keep the code paths simple and minimal, and IMHO this patch isn't worth the gains in complexity.

Member

jamwt commented Oct 12, 2011

I'd prefer to keep the code paths simple and minimal, and IMHO this patch isn't worth the gains in complexity.

@jamwt jamwt closed this Oct 12, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment