This repository has been archived by the owner on May 24, 2022. It is now read-only.
Don't put in ringbuffer data that could be sent directly. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a micro optimization designed to decrease latency.
|
I'd prefer to keep the code paths simple and minimal, and IMHO this patch isn't worth the gains in complexity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is some micro optimization. I have written it in hope to decrease latency but this does not work. However, it increases performances by about 6% on my benchmarks. Maybe this is not worth introducing such optimizations (and I am not sure this is correct, for example SSL_write could trigger a new handshake and in this case, I hope that the next SSL_write will still trigger it).