v1.2 is more picky about 'namespaced' gem names #2075

Closed
jdelStrother opened this Issue Aug 23, 2012 · 1 comment

4 participants

@jdelStrother

Hi,
My gemfile was fine with bundler 1.2 up until 67c6fcb, at which point I started getting load errors.
I had gem 'bcrypt-ruby' in my Gemfile... 'bcrypt-ruby' doesn't actually exist in my load path, and neither does 'bcrypt/ruby', so I got the following error :

/Users/jon/.rvm/gems/ruby-1.9.3-p194@abweb/gems/bundler-1.2.0.rc.2/lib/bundler/runtime.rb:74:in `require': cannot load such file -- bcrypt/ruby (LoadError)
from /Users/jon/.rvm/gems/ruby-1.9.3-p194@abweb/gems/bundler-1.2.0.rc.2/lib/bundler/runtime.rb:74:in `rescue in block in require'
from /Users/jon/.rvm/gems/ruby-1.9.3-p194@abweb/gems/bundler-1.2.0.rc.2/lib/bundler/runtime.rb:62:in `block in require'
from /Users/jon/.rvm/gems/ruby-1.9.3-p194@abweb/gems/bundler-1.2.0.rc.2/lib/bundler/runtime.rb:55:in `each'
from /Users/jon/.rvm/gems/ruby-1.9.3-p194@abweb/gems/bundler-1.2.0.rc.2/lib/bundler/runtime.rb:55:in `require'
from /Users/jon/.rvm/gems/ruby-1.9.3-p194@abweb/gems/bundler-1.2.0.rc.2/lib/bundler.rb:128:in `require'
from /Users/jon/Developer/web/config/application.rb:9:in `<top (required)>'
...

So it seems like v1.1.5 silently fails to load bcrypt-ruby...which seems a bit odd, but I never noticed it, since I was manually requiring 'bcrypt' in my files that needed it.

As far as I can tell, the 1.2 behaviour is probably the correct one, but perhaps we should point it out in the upgrade notes for people moving to 1.2. I'm not quite sure why 1.1.5 just swallows up the exception - anyone know?

@indirect
Bundler member
@hone hone was assigned Aug 24, 2012
@hone hone added a commit that closed this issue Aug 25, 2012
@hone hone Fix #2075. Return to old namespace behavior.
$1 gets overidden by gsub.
6d87967
@hone hone closed this in 6d87967 Aug 25, 2012
@hone hone added a commit that referenced this issue Aug 25, 2012
@hone hone Fix #2075. Return to old namespace behavior.
$1 gets overidden by gsub.
3cadcec
@evanphx evanphx was assigned Aug 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment