This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
api calls now get retried #2561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e all Fetcher class instance variables
|
@joshk someone ❤️s you! |
|
@flyinprogramer thanks for implementing this! I'll review it and hopefully get it merged soon. :) |
|
SUPER AWSOME!!!! |
|
just trying to learn and give back - hopefully it's what ya'll were/are looking for! |
|
👍 to this change. Everyone who runs bundler a lot in their tests environments will <3 this. |
Closed
|
this is now tech debt assuming #2601 gets pulled in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also made api_timeout, redirect_limit, and max_retries Fetcher class instance variables.
This is so we can set them with out warning (prior they were constants) at the class level, and all future instances of a Fetcher get the set variables, but can be individually changed as well.
This is in response to this issue:
#2421
As well as a personal need for the api call to be retried.
If there's anything I can do to improve the quality of this request, or anything, please don't hesitate to teach me something!