New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.14: the one with the platforms, finally #4853

Closed
indirect opened this Issue Aug 9, 2016 · 7 comments

Comments

@indirect
Member

indirect commented Aug 9, 2016

  • create stable branch after 1.13 final to unblock 2.0 merge
  • merge new platform support #4836
    • bundler treats distinct platforms as identical (see also #4295, https://rubygems.org/gems/google-protobuf/versions)
    • bundler seems to complain about broken lockfiles when they have more than one platform (???) #4620 (comment)
    • users on windows need to be able to deploy to heroku, which is currently impossible bc heroku needs ruby/source gems but windows devs lock to (one of) the windows binaries. maybe this is fixed by lock --add-platform ruby?
    • Add an option to force Bundler to only use Gem::Platform::RUBY #4895 #4813
  • Create a (predictably-named) tmpdir if it's impossible to write the compact index to $HOME
  • final trampoline messaging PR
  • default enable trampolining to locked versions "~> 2" #4894
  • env/setting to enable trampolining to any version (BUNDLE_ENABLE_TRAMPOLINE)
  • announcement/docs for platform support & commands
  • announcement/docs for bundler locking option
  • website guide on how to use bundler across platforms
  • website guide on how to use bundler locking

@indirect indirect added this to the 1.X -- Better Platform Support milestone Aug 9, 2016

@indirect indirect referenced this issue Aug 9, 2016

Closed

2.0: a whole new world #4856

14 of 14 tasks complete
@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins Aug 9, 2016

Member

option to resolve respecting running ruby versions

I thought we agreed to move this to 2.0?

Add an option to force Bundler to only use Gem::Platform::RUBY #4813

Maybe it makes sense to make this a gemfile DSL thing? where you just specify the list of platforms you want to support (and we don't implicitly add any new platforms)?

Member

segiddins commented Aug 9, 2016

option to resolve respecting running ruby versions

I thought we agreed to move this to 2.0?

Add an option to force Bundler to only use Gem::Platform::RUBY #4813

Maybe it makes sense to make this a gemfile DSL thing? where you just specify the list of platforms you want to support (and we don't implicitly add any new platforms)?

homu added a commit that referenced this issue Aug 20, 2016

Auto merge of #4894 - bundler:seg-enable-trampoline-2.0, r=indirect
[PostitTrampoline] Automatically enable when target version is >= 2

See #4853
@indirect

This comment has been minimized.

Show comment
Hide comment
@indirect

indirect Sep 10, 2016

Member

option to resolve respecting running ruby versions
I thought we agreed to move this to 2.0?

@segiddins I was under the impression that we agreed to delay raising exceptions until 2.0, but it's fully backwards-compatible to auto-lock and then print a warning when there's no ruby in the Gemfile and the running ruby doesn't match the locked ruby. Raising when the running ruby doesn't match the auto-locked ruby breaks backwards compat, so we need to wait on that.

Member

indirect commented Sep 10, 2016

option to resolve respecting running ruby versions
I thought we agreed to move this to 2.0?

@segiddins I was under the impression that we agreed to delay raising exceptions until 2.0, but it's fully backwards-compatible to auto-lock and then print a warning when there's no ruby in the Gemfile and the running ruby doesn't match the locked ruby. Raising when the running ruby doesn't match the auto-locked ruby breaks backwards compat, so we need to wait on that.

@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins Sep 11, 2016

Member

Sure, but we'll need test coverage to fully flesh this out

Member

segiddins commented Sep 11, 2016

Sure, but we'll need test coverage to fully flesh this out

@indirect

This comment has been minimized.

Show comment
Hide comment
@indirect

indirect Oct 3, 2016

Member

@segiddins btw, are you planning to write the docs in this checklist?

Member

indirect commented Oct 3, 2016

@segiddins btw, are you planning to write the docs in this checklist?

@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins Oct 3, 2016

Member

I had no immediate plans to, I figured I'd let someone else participate in the release :P

Member

segiddins commented Oct 3, 2016

I had no immediate plans to, I figured I'd let someone else participate in the release :P

@lynncyrin

This comment has been minimized.

Show comment
Hide comment
@lynncyrin

lynncyrin Oct 3, 2016

Member
  • add documentation for force_ruby_platform #5028
Member

lynncyrin commented Oct 3, 2016

  • add documentation for force_ruby_platform #5028

bundlerbot added a commit that referenced this issue Dec 27, 2016

Auto merge of #5276 - bundler:seg-platform-docs, r=indirect
Document 1.14 platform changes

See #4853

@indirect feel free to add any other docs you think might be helpful to this branch

bundlerbot added a commit that referenced this issue Dec 27, 2016

Auto merge of #5276 - bundler:seg-platform-docs, r=indirect
Document 1.14 platform changes

See #4853

@indirect feel free to add any other docs you think might be helpful to this branch
@segiddins

This comment has been minimized.

Show comment
Hide comment
@segiddins

segiddins Jan 21, 2017

Member

1.14 was released

Member

segiddins commented Jan 21, 2017

1.14 was released

@segiddins segiddins closed this Jan 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment