Warnings #1403

Merged
merged 3 commits into from Sep 17, 2011

2 participants

@stephencelis

This pull request fixes a few warnings I encounter with the -w flag enabled when I run bundle exec rake.

@indirect
Bundler member

I'm sorry, but this patch totally doesn't work for me. I'd like to remove the warnings, perhaps you could fix it?


[andre ~/sw/gems/bundler](1-0-stable)$ RUBYOPT='-w' dbundle exec rake
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/pathname.rb:263: warning: `*' interpreted as argument prefix
/Users/andre/sw/gems/bundler/lib/bundler/rubygems_ext.rb:155:in `remove_method': method `hash' not defined in Gem::Platform (NameError)
    from /Users/andre/sw/gems/bundler/lib/bundler/rubygems_ext.rb:155
    from /Users/andre/sw/gems/bundler/lib/bundler.rb:11:in `require'
    from /Users/andre/sw/gems/bundler/lib/bundler.rb:11
    from /Users/andre/sw/gems/bundler/bin/bundle:4:in `require'
    from /Users/andre/sw/gems/bundler/bin/bundle:4
@stephencelis

Hm, that's odd. If the call to method_defined? returns true, then remove_method shouldn't blow up.

What version of Ruby (patch level, if possible, please) and RubyGems are you running?

@indirect
Bundler member
[andre ~/sw/gems/bundler](1-0-stable⚡)$ ruby -v
ruby 1.8.7 (2010-01-10 patchlevel 249) [universal-darwin11.0]
[andre ~/sw/gems/bundler](1-0-stable⚡)$ gem -v
1.3.7
@stephencelis

Alright, fixed the 1.8.7 case and caught one more warning. Specs run cleanly in 1.8 and 1.9.

@indirect indirect merged commit 67cfb2f into bundler:1-0-stable Sep 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment