Added documentation of the new :github option for gemfiles #1848

Merged
merged 1 commit into from Apr 13, 2012

Conversation

Projects
None yet
3 participants
@zofrex
Contributor

zofrex commented Apr 13, 2012

This should also probably go up on the bundler website docs, as every :git example there uses github and it's a nice shorthand :)

radar added a commit that referenced this pull request Apr 13, 2012

Merge pull request #1848 from ZoFreX/master
Added documentation of the new :github option for gemfiles

@radar radar merged commit d195524 into bundler:master Apr 13, 2012

@radar

This comment has been minimized.

Show comment
Hide comment
@radar

radar Apr 13, 2012

Contributor

Thanks! Happy friday!

Contributor

radar commented Apr 13, 2012

Thanks! Happy friday!

+
+Are both equivalent to
+
+ gem "rails", :github => :git://github.com/rails/rails.git"

This comment has been minimized.

@jhlllnd

jhlllnd Apr 16, 2012

I think it should be:
gem "rails", :git => "git://github.com/rails/rails.git"

@jhlllnd

jhlllnd Apr 16, 2012

I think it should be:
gem "rails", :git => "git://github.com/rails/rails.git"

This comment has been minimized.

@zofrex

zofrex Apr 16, 2012

Contributor

You are absolutely correct! Rolling a new pull request to fix that :)

@zofrex

zofrex Apr 16, 2012

Contributor

You are absolutely correct! Rolling a new pull request to fix that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment