Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Ensure packaged git repos works when using install with --path option #1989

Closed
wants to merge 1 commit into from

3 participants

Adrien Coquio Don't Add Me To Your Organization a.k.a The Travis Bot José Valim
Adrien Coquio

This and #1988 are failing spec for #1970.
Not sure if this is the best place to put this tests, let me know if I can improve :)
cc @josevalim

Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request fails (merged 00b4b10 into 68bdb44).

José Valim josevalim was assigned
José Valim
Collaborator

Thanks, I assigned it to me and it will be taken care before the final release.

José Valim josevalim closed this in 51aaf18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 16 additions and 12 deletions.
  1. +16 −12 spec/cache/git_spec.rb
28 spec/cache/git_spec.rb
View
@@ -14,20 +14,24 @@
%w(cache package).each do |cmd|
describe "bundle #{cmd} with git" do
- it "copies repository to vendor cache and uses it" do
- git = build_git "foo"
- ref = git.ref_for("master", 11)
- install_gemfile <<-G
- gem "foo", :git => '#{lib_path("foo-1.0")}'
- G
+ ["install", "install --path vendor/bundle"].each do |install_cmd|
+ it "copies repository to vendor cache and uses it when using #{install_cmd}" do
+ git = build_git "foo"
+ ref = git.ref_for("master", 11)
- bundle "#{cmd} --all"
- bundled_app("vendor/cache/foo-1.0-#{ref}").should exist
- bundled_app("vendor/cache/foo-1.0-#{ref}/.git").should_not exist
+ gemfile <<-G
+ gem "foo", :git => '#{lib_path("foo-1.0")}'
+ G
- FileUtils.rm_rf lib_path("foo-1.0")
- should_be_installed "foo 1.0"
+ bundle install_cmd
+ bundle "#{cmd} --all"
+ bundled_app("vendor/cache/foo-1.0-#{ref}").should exist
+ bundled_app("vendor/cache/foo-1.0-#{ref}/.git").should_not exist
+
+ FileUtils.rm_rf lib_path("foo-1.0")
+ should_be_installed "foo 1.0"
+ end
end
it "runs twice without exploding" do
@@ -121,4 +125,4 @@
should_be_installed "has_submodule 1.0"
end
end
-end
+end
Something went wrong with that request. Please try again.