lib/bundler/settings.rb: Always respect Bundler.ruby_scope #2083

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@godfat
godfat commented Sep 1, 2012

I have a long standing headache that ~/.bundle/config works
differently than /path/to/project/.bundle/config.
This would make them work the same way, respecting ruby scope.
Not sure if this would have other side-effects,
but really the config should have the same meaning!

Thanks!

@godfat godfat lib/bundler/settings.rb: Always respect Bundler.ruby_scope
I have a long standing headache that ~/.bundle/config works
differently than /path/to/project/.bundle/config.
This would make them work the same way, respecting ruby scope.
Not sure if this would have other side-effects,
but really the config should have the same meaning!
5e6b20e
@travisbot

This pull request fails (merged 5e6b20e into 3110341).

@travisbot

This pull request fails (merged 841881f into 3110341).

@indirect
Member

I would like this to be the case, but because Bundler conforms to SemVer, it will have to wait for Bundler 2.0. I have merged this pull as ab4dc8a into the 2-0-dev branch. Thanks for the pull and the blog post explaining!

@indirect indirect closed this Feb 19, 2013
@godfat
godfat commented Feb 20, 2013

Thank you very much for merging this. This strongly encourages me to
do further improvement on bundler in the future. :) Like, how to avoid
environment variables pollution would be my next target.

@indirect
Member

Sounds great! :)

On Feb 19, 2013, at 11:00 PM, "Lin Jen-Shin (godfat)" notifications@github.com wrote:

Thank you very much for merging this. This strongly encourages me to
do further improvement on bundler in the future. :) Like, how to avoid
environment variables pollution would be my next target.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment