Skip to content

Added the --ext option to the gem command. #2891

Closed
wants to merge 3 commits into from

4 participants

@andremedeiros
Bundler member

This generates a basic skeleton for building C extensions.

@indirect
Bundler member

Aren't slashes supposed to turn into modules/directories in the gem naming convention? I'm a hair worried about turning dashes into underscores. :P

@andremedeiros
Bundler member

I see what you mean, but typically C extensions won't have nested Modules (look at Mysql2, Nokogiri, etc).

If you believe it should behave differently, care to expand on it so I can fix it? ;-)

@indirect
Bundler member

Maybe just raise an exception if the gem with an extension has a dash in the name? "C extensions don't have namespaces what are you doing go read the rubygems guide about naming" or something like that.

@andremedeiros
Bundler member

That's a good way of doing it. Let me find some documentation to link to and I'll get it fixed in the next 15 minutes.

@andremedeiros
Bundler member

That should do the trick!

@iurimatias

👍

@zzak zzak added a commit to zzak/bundler that referenced this pull request Mar 3, 2014
@zzak zzak Fixed failure in bundle gem command spec due to extra newline added in 12428c2
@zzak zzak added a commit to zzak/bundler that referenced this pull request Mar 3, 2014
@zzak zzak Fixed failure in bundle gem command spec due to extra newline added in 6a04e5b
@zzak
Bundler member
zzak commented Mar 3, 2014

Committed manually by f3321c7

@zzak zzak closed this Mar 3, 2014
@zzak
Bundler member
zzak commented Mar 3, 2014

also 3f557a4, 49aa6aa, and 6a04e5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.