This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Pessimistic test framework versions for bundle gem command #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a pessimistic version requirement for RSpec and Minitest in gemspecs generated by the `bundle gem` command. It is best practice to at least depend on major versions of development dependency gems. * Hard code major versions of the two testing frameworks. * Add a spec that tests that only specific version requirements are used in development dependencies.
|
Not sure why the specs are failing for Rubygems < 2.0. |
|
A couple of reasons... the guard removal code wasn't actually being called where you inserted the test, and the |
|
Thanks! 👍 |
homu
added a commit
that referenced
this pull request
Jul 27, 2015
Depend on major version of test gems Use a pessimistic version requirement for RSpec and Minitest in gemspecs generated by the bundle gem command. It is best practice to at least depend on major versions of development dependency gems. refs #3811
homu
added a commit
that referenced
this pull request
Jul 28, 2015
Depend on major version of test gems Use a pessimistic version requirement for RSpec and Minitest in gemspecs generated by the bundle gem command. It is best practice to at least depend on major versions of development dependency gems. refs #3811
|
Merged in 26c4665. Thanks for the feature! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first draft of the change discussed in #3806.
Use a pessimistic version requirement for RSpec and Minitest in
gemspecs generated by the
bundle gemcommand. It is best practice toat least depend on major versions of development dependency gems.
used in development dependencies.
Some questions:
bundle gemcontains some duplication for cases concerning different gem names (with dash, with underscore etc). The shared example group that I added could have been used in more of the nested contexts, but I did not feel that those were testing different paths in my case.Looking forward to your feedback.