New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow signed tags on rake release #4824

Merged
merged 1 commit into from Aug 4, 2016

Conversation

Projects
None yet
5 participants
@spk
Contributor

spk commented Jul 30, 2016

Removing --annotate option does not change default behaviour

Since git 2.9.0 its possible to configure signed tag with
tag.forceSignAnnotated to true

Cheers

Allow signed tags on rake release
Removing `--annotate` option does not change default behaviour

Since git 2.9.0 its possible to configure signed tag with
`tag.forceSignAnnotated` to true
@segiddins

This comment has been minimized.

Member

segiddins commented Jul 30, 2016

@indirect

This comment has been minimized.

Member

indirect commented Aug 4, 2016

It doesn't actually do anything, but sure. @homu r+

@homu

This comment has been minimized.

Contributor

homu commented Aug 4, 2016

📌 Commit 711a2e7 has been approved by indirect

@homu

This comment has been minimized.

Contributor

homu commented Aug 4, 2016

⌛️ Testing commit 711a2e7 with merge c5e902f...

homu added a commit that referenced this pull request Aug 4, 2016

Auto merge of #4824 - spk:optionable-annotate-tag, r=indirect
Allow signed tags on rake release

Removing `--annotate` option does not change default behaviour

Since git 2.9.0 its possible to configure signed tag with
`tag.forceSignAnnotated` to true

Cheers
@homu

This comment has been minimized.

Contributor

homu commented Aug 4, 2016

☀️ Test successful - status

@homu homu merged commit 711a2e7 into bundler:master Aug 4, 2016

3 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@spk spk deleted the spk:optionable-annotate-tag branch Sep 5, 2016

@lynncyrin lynncyrin modified the milestone: Release Archive Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment