New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Definition] Print a helpful warning when a dependency is unused on a… #5003

Merged
merged 2 commits into from Sep 30, 2016

Conversation

Projects
None yet
4 participants
@segiddins
Copy link
Member

segiddins commented Sep 19, 2016

…ny platform

Should help address the confusion caused by #5001

@indirect

This comment has been minimized.

Copy link
Member

indirect commented Sep 20, 2016

This is a good warning! That said, I'm not sure how this fixes the bug described in #5001. In that ticket, the Gemfile no longer contains a platform declaration at all, and the gem is still ignored. Seems like a different problem.

@segiddins

This comment has been minimized.

Copy link
Member

segiddins commented Sep 20, 2016

That's not fixable without completely re-writing large parts of definition.

@indirect

This comment has been minimized.

Copy link
Member

indirect commented Sep 20, 2016

Assuming that is true, it still doesn't change the fact that this is solving a different problem than the one reported in #5001, does it?

@segiddins

This comment has been minimized.

Copy link
Member

segiddins commented Sep 20, 2016

No, but it might help address the confusion by printing a warning in that case (saying that something out of the ordinary is taking place)

@indirect

This comment has been minimized.

Copy link
Member

indirect commented Sep 30, 2016

@homu r+

@homu

This comment has been minimized.

Copy link
Contributor

homu commented Sep 30, 2016

📌 Commit f7f6087 has been approved by indirect

homu added a commit that referenced this pull request Sep 30, 2016

Auto merge of #5003 - bundler:seg-warn-unused-deps, r=indirect
[Definition] Print a helpful warning when a dependency is unused on a…

…ny platform

Should help address the confusion caused by #5001
@homu

This comment has been minimized.

Copy link
Contributor

homu commented Sep 30, 2016

⌛️ Testing commit f7f6087 with merge 5ee7613...

@homu

This comment has been minimized.

Copy link
Contributor

homu commented Sep 30, 2016

☀️ Test successful - status

@homu homu merged commit f7f6087 into master Sep 30, 2016

3 checks passed

codeclimate Code Climate didn't find any new or fixed issues.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@lynncyrin lynncyrin modified the milestone: 1.13 - Release 1.13.2 Sep 30, 2016

@segiddins segiddins deleted the seg-warn-unused-deps branch Dec 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment