New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Add `—all` flag to `bundle update` #5722

Merged
merged 6 commits into from Jun 15, 2017

Conversation

Projects
None yet
3 participants
@segiddins
Member

segiddins commented Jun 14, 2017

What was the end-user problem that led to this PR?

The problem was that some users would think they needed to run bundle update instead of bundle install, and we want such a (potentially) destructive action to require more explicit user approval.

Was was your diagnosis of the problem?

My diagnosis was that bundle update shouldn't implicitly update everything without an acknowledgement that it will do so.

What is your fix for the problem, implemented in this PR?

My fix, based on #2646, it to require bundle update --all for the current bundle update behavior.

Why did you choose this fix out of the possible options?

I chose this fix because it was already on 2-0-dev, courtesy of bundler/bundler-features#18.

segiddins added some commits Jun 14, 2017

[Install] Avoid re-writing settings when they won’t change
This will avoid spurious deprecation warnings
Add `—all` flag to `bundle update`
And require it on 2+
@indirect

This comment has been minimized.

Show comment
Hide comment
@indirect
Member

indirect commented Jun 15, 2017

@bundlerbot

This comment has been minimized.

Show comment
Hide comment
@bundlerbot

bundlerbot Jun 15, 2017

Contributor

📌 Commit 237f035 has been approved by indirect

Contributor

bundlerbot commented Jun 15, 2017

📌 Commit 237f035 has been approved by indirect

@segiddins segiddins changed the title from Add `—all` flag to `bundle update` to [2.0] Add `—all` flag to `bundle update` Jun 15, 2017

@bundlerbot

This comment has been minimized.

Show comment
Hide comment
@bundlerbot

bundlerbot Jun 15, 2017

Contributor

⌛️ Testing commit 237f035 with merge 08d1fa6...

Contributor

bundlerbot commented Jun 15, 2017

⌛️ Testing commit 237f035 with merge 08d1fa6...

bundlerbot added a commit that referenced this pull request Jun 15, 2017

Auto merge of #5722 - bundler:seg-update-all-flag, r=indirect
Add `—all` flag to `bundle update`

### What was the end-user problem that led to this PR?

The problem was that some users would think they needed to run `bundle update` instead of `bundle install`, and we want such a (potentially) destructive action to require more explicit user approval.

### Was was your diagnosis of the problem?

My diagnosis was that `bundle update` shouldn't implicitly update _everything_ without an acknowledgement that it will do so.

### What is your fix for the problem, implemented in this PR?

My fix, based on #2646, it to require `bundle update --all` for the current `bundle update` behavior.

### Why did you choose this fix out of the possible options?

I chose this fix because it was already on 2-0-dev, courtesy of bundler/bundler-features#18.
@bundlerbot

This comment has been minimized.

Show comment
Hide comment
@bundlerbot

bundlerbot Jun 15, 2017

Contributor

☀️ Test successful - status-travis
Approved by: indirect
Pushing 08d1fa6 to master...

Contributor

bundlerbot commented Jun 15, 2017

☀️ Test successful - status-travis
Approved by: indirect
Pushing 08d1fa6 to master...

@bundlerbot bundlerbot merged commit 237f035 into master Jun 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@segiddins segiddins deleted the seg-update-all-flag branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment