Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop gitignoring Gemfile.lock in default template #5822

Merged
merged 1 commit into from Jul 19, 2017

Conversation

Projects
None yet
5 participants
@deivid-rodriguez
Copy link
Contributor

deivid-rodriguez commented Jun 27, 2017

This will be followed up with a documentation PR on some best practices to keep gems tested against up to date dependencies.

What was the end-user problem that led to this PR?

The problem was that sometimes open source contributors get discouraged because they can't setup the project they want to contribute to easily.

Was was your diagnosis of the problem?

My diagnosis was that a lot of projects gitignore Gemfile.lock just because it's gitignored by default in the new gem template. This causes bundle install to no longer be guaranteed to work. And bundle install is usually the first step towards a contribution.

What is your fix for the problem, implemented in this PR?

My fix was to remove the Gemfile.lock entry from the gitignore template.

Why did you choose this fix out of the possible options?

I chose this fix because to prevent a file from being gitignored, removing it from the .gitignore file usually does the trick :)

@bundlerbot

This comment has been minimized.

Copy link
Contributor

bundlerbot bot commented Jun 27, 2017

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

@segiddins segiddins requested a review from indirect Jul 7, 2017

@segiddins

This comment has been minimized.

Copy link
Member

segiddins commented Jul 19, 2017

@indirect

This comment has been minimized.

Copy link
Member

indirect commented Jul 19, 2017

@deivid-rodriguez thanks for the discussion around this and the PR! looks good. 👍

@bundlerbot r+

@bundlerbot

This comment has been minimized.

Copy link
Contributor

bundlerbot commented Jul 19, 2017

📌 Commit d6b322f has been approved by indirect

@bundlerbot

This comment has been minimized.

Copy link
Contributor

bundlerbot commented Jul 19, 2017

⌛️ Testing commit d6b322f with merge c36fb8b...

bundlerbot added a commit that referenced this pull request Jul 19, 2017

Auto merge of #5822 - deivid-rodriguez:dont_gitignore_lockfiles, r=in…
…direct

Stop gitignoring Gemfile.lock in default template

This will be followed up with a documentation PR on some best practices to keep gems tested against up to date dependencies.

### What was the end-user problem that led to this PR?

The problem was that sometimes open source contributors get discouraged because they can't setup the project they want to contribute to easily.

### Was was your diagnosis of the problem?

My diagnosis was that a lot of projects gitignore `Gemfile.lock` just because it's gitignored by default in the new gem template. This causes `bundle install` to no longer be guaranteed to work. And `bundle install` is usually the first step towards a contribution.

### What is your fix for the problem, implemented in this PR?

My fix was to remove the `Gemfile.lock` entry from the gitignore template.

### Why did you choose this fix out of the possible options?

I chose this fix because to prevent a file from being gitignored, removing it from the `.gitignore` file usually does the trick :)
@bundlerbot

This comment has been minimized.

Copy link
Contributor

bundlerbot commented Jul 19, 2017

☀️ Test successful - status-travis
Approved by: indirect
Pushing c36fb8b to master...

@bundlerbot bundlerbot merged commit d6b322f into bundler:master Jul 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez:dont_gitignore_lockfiles branch Jul 19, 2017

@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor Author

deivid-rodriguez commented Jul 19, 2017

@indirect Thanks to you! I'll follow up with a documentation PR as soon as I find time.

@indirect

This comment has been minimized.

Copy link
Member

indirect commented Jul 20, 2017

@deivid-rodriguez awesome! I created a tracking issue for that over here: #5879

@mvz

This comment has been minimized.

Copy link
Contributor

mvz commented on d6b322f Sep 7, 2017

Why?

This comment has been minimized.

Copy link
Member

indirect replied Sep 7, 2017

@mvz there is an explanation in the linked PR: #5822

This comment has been minimized.

Copy link
Contributor

mvz replied Sep 7, 2017

@indirect thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.