Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Stop gitignoring Gemfile.lock in default template #5822
This will be followed up with a documentation PR on some best practices to keep gems tested against up to date dependencies.
What was the end-user problem that led to this PR?
The problem was that sometimes open source contributors get discouraged because they can't setup the project they want to contribute to easily.
Was was your diagnosis of the problem?
My diagnosis was that a lot of projects gitignore
What is your fix for the problem, implemented in this PR?
My fix was to remove the
Why did you choose this fix out of the possible options?
I chose this fix because to prevent a file from being gitignored, removing it from the
Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.
We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.
If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.
For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide