New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI::GEM] bundle gem will generate homepage_uri and code and changelog section … #6697

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
4 participants
@walf443
Contributor

walf443 commented Sep 12, 2018

What was the end-user problem that led to this PR?

The problem was I always have to remember how to add CHANGELOG.md when I set up a new gem.

What was your diagnosis of the problem?

My diagnosis was that CHANGELOG.md has become enough of a community standard that it makes sense to offer it in bundle gem.

What is your fix for the problem, implemented in this PR?

My fix is only added metadata[:changelog_uri] to generated gemspec file.
Changelog.md file is not generated by default.

Why did you choose this fix out of the possible options?

I chose this fix because Changelog.md file format is different by projects.

@bundlerbot

This comment has been minimized.

Show comment
Hide comment
@bundlerbot

bundlerbot bot Sep 12, 2018

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

bundlerbot bot commented Sep 12, 2018

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

@walf443

This comment has been minimized.

Show comment
Hide comment
@walf443

walf443 Sep 12, 2018

Contributor

rubygems link in changelog_uri was introduced by https://github.com/rubygems/rubygems.org/pull/1553/files

Contributor

walf443 commented Sep 12, 2018

rubygems link in changelog_uri was introduced by https://github.com/rubygems/rubygems.org/pull/1553/files

@greysteil

Makes a lot of sense to me - thanks for the contribution! I'll leave open for 24 hours for others to chime in on, and merge if no-one has any other feedback.

@walf443

This comment has been minimized.

Show comment
Hide comment
@walf443

walf443 Sep 12, 2018

Contributor

oh. I'll try to fix test.

Contributor

walf443 commented Sep 12, 2018

oh. I'll try to fix test.

@hsbt hsbt self-assigned this Sep 12, 2018

@hsbt

This comment has been minimized.

Show comment
Hide comment
@hsbt

hsbt Sep 12, 2018

Member

@walf443 Thanks. I will merge this after test passes.

Member

hsbt commented Sep 12, 2018

@walf443 Thanks. I will merge this after test passes.

@walf443

This comment has been minimized.

Show comment
Hide comment
@walf443

walf443 Sep 14, 2018

Contributor

@hsbt I'm sorry to be late to fix test.

Contributor

walf443 commented Sep 14, 2018

@hsbt I'm sorry to be late to fix test.

@hsbt

This comment has been minimized.

Show comment
Hide comment
@hsbt
Member

hsbt commented Sep 14, 2018

@bundlerbot

This comment has been minimized.

Show comment
Hide comment
@bundlerbot

bundlerbot Sep 14, 2018

Contributor

📌 Commit f78645d has been approved by hsbt

Contributor

bundlerbot commented Sep 14, 2018

📌 Commit f78645d has been approved by hsbt

@bundlerbot

This comment has been minimized.

Show comment
Hide comment
@bundlerbot

bundlerbot Sep 14, 2018

Contributor

⌛️ Testing commit f78645d with merge c7ed6a2...

Contributor

bundlerbot commented Sep 14, 2018

⌛️ Testing commit f78645d with merge c7ed6a2...

bundlerbot added a commit that referenced this pull request Sep 14, 2018

Auto merge of #6697 - walf443:added_changelog_section, r=hsbt
[CLI::GEM] bundle gem will generate homepage_uri and code and changelog section …

### What was the end-user problem that led to this PR?

The problem was I always have to remember how to add CHANGELOG.md  when I set up a new gem.

### What was your diagnosis of the problem?

My diagnosis was that CHANGELOG.md has become enough of a community standard that it makes sense to offer it in bundle gem.

### What is your fix for the problem, implemented in this PR?

My fix is only added metadata[:changelog_uri] to generated gemspec file.
Changelog.md file is not generated by default.

### Why did you choose this fix out of the possible options?

I chose this fix because Changelog.md file format is different by projects.
@bundlerbot

This comment has been minimized.

Show comment
Hide comment
@bundlerbot

bundlerbot Sep 14, 2018

Contributor

☀️ Test successful - status-travis
Approved by: hsbt
Pushing c7ed6a2 to master...

Contributor

bundlerbot commented Sep 14, 2018

☀️ Test successful - status-travis
Approved by: hsbt
Pushing c7ed6a2 to master...

@bundlerbot bundlerbot merged commit f78645d into bundler:master Sep 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment