Add Bundle.require on standalone version #870

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@leobessa
Contributor

leobessa commented Nov 22, 2010

No description provided.

@indirect

This comment has been minimized.

Show comment Hide comment
@indirect

indirect May 11, 2011

Owner

Any chance of documentation or tests for this? I honestly have no idea what this does or why I would want to pull it :)

Owner

indirect commented May 11, 2011

Any chance of documentation or tests for this? I honestly have no idea what this does or why I would want to pull it :)

@leobessa

This comment has been minimized.

Show comment Hide comment
@leobessa

leobessa May 13, 2011

Contributor

You are right!

I need to write the test and document it.

The idea behind the this commit is to provide a way to require the gems (in production) without bundler.

The method Bundler.require would be available and work properly, but without the bundler gem.
Maybe to provide a file called "bundler/require" would be a better option.

What do you think?

Contributor

leobessa commented May 13, 2011

You are right!

I need to write the test and document it.

The idea behind the this commit is to provide a way to require the gems (in production) without bundler.

The method Bundler.require would be available and work properly, but without the bundler gem.
Maybe to provide a file called "bundler/require" would be a better option.

What do you think?

@indirect

This comment has been minimized.

Show comment Hide comment
@indirect

indirect May 14, 2011

Owner

I think Bundler.require is probably better to maintain API between standalone and regular.

Owner

indirect commented May 14, 2011

I think Bundler.require is probably better to maintain API between standalone and regular.

@indirect

This comment has been minimized.

Show comment Hide comment
@indirect

indirect May 22, 2011

Owner

After looking at this more carefully, I think this is a good idea, and I will pull it as soon as it has some specs that cover using Bundler.require after a standalone install. If you don't want to write a spec yourself, I'll probably get around to it at some point. :)

Owner

indirect commented May 22, 2011

After looking at this more carefully, I think this is a good idea, and I will pull it as soon as it has some specs that cover using Bundler.require after a standalone install. If you don't want to write a spec yourself, I'll probably get around to it at some point. :)

@leobessa

This comment has been minimized.

Show comment Hide comment
@leobessa

leobessa May 24, 2011

Contributor

OK.

I'll write the specs.

Contributor

leobessa commented May 24, 2011

OK.

I'll write the specs.

@alwyn

This comment has been minimized.

Show comment Hide comment
@alwyn

alwyn Jan 12, 2012

Am I correct that Bundler.require is still not available in standalone and that it is still a 'feature' and not a bug?

alwyn commented Jan 12, 2012

Am I correct that Bundler.require is still not available in standalone and that it is still a 'feature' and not a bug?

@indirect

This comment has been minimized.

Show comment Hide comment
@indirect

indirect Jan 12, 2012

Owner

Yes. There's more discussion on the pull request from cowboyd.

Owner

indirect commented Jan 12, 2012

Yes. There's more discussion on the pull request from cowboyd.

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Apr 29, 2012

This pull request fails (merged 2287263 into 2016e47).

This pull request fails (merged 2287263 into 2016e47).

@indirect indirect closed this Aug 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment