This fixes tests on 1.9.3 #968

Merged
2 commits merged into from Jan 21, 2011

Conversation

Projects
None yet
4 participants
Contributor

tenderlove commented Jan 19, 2011

Rubygems 1.5.0 doesn't require all files that it did in previous versions. This branch adds the proper require statements to bundler. This branch also fixes warnings emitted by psych when dumping YAML.

This commit changes the default YAML parser to Psych for all gems, which may introduce subtle breakage. I personally ran into this in Rails 2.3: https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/6354-psych-does-not-handle-symbols-in-yaml-used-in-activesupport

I'm not sure if this is a Bundler issue, or if any problems should be reported to the application or Psych. FWIW, Rails 3.0 seems to have worked around it, so I assume they acknowledge it to be an issue there, and I've reported one for 2.3.

Contributor

ndbroadbent replied Mar 1, 2011

Is it possible that 'psych' is breaking the YAML output of ".bundle/config"?
It appears to us that between 1.0.9 and 1.0.10, the command "bundle install --deployment" has been broken, and no longer writes to ".bundle/config".
It could be an issue with our server configuration though, so it would be great to have this verified by someone else.

It's a very bad idea to add 'psych' instead of default 'syck' for 'yaml'. I have an issue with this in bundler 1.0.10 and ruby 1.9.2 because psych has a big issue with aliased sections in yaml. Now, to fix it, I should do require 'yaml' before require 'bunler' in rails-script.

See https://gist.github.com/809309 for reproduce. I've created bug https://github.com/carlhuda/bundler/issues/issue/1010

@krekoten krekoten pushed a commit that referenced this pull request Apr 17, 2011

@indirect indirect Merge pull request #968 from tenderlove/bundler
---

Rubygems 1.5.0 doesnt require all files that it did in previous versions.  This branch adds the proper require statements to bundler.  This branch also fixes warnings emitted by psych when dumping YAML.
4dbbc4a

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment