Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed some methods visibility properties for make History behavior more extendable #10

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@VictorSuhov
Copy link
Contributor

commented Jul 10, 2019

I try to extend saveHistory() method logic, but cannot call methods getTableName, getCreatedBy, getRowId and isEquals because they all have a private visibility properties.

@coveralls

This comment has been minimized.

Copy link

commented Jul 10, 2019

Pull Request Test Coverage Report for Build 19

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.074%

Totals Coverage Status
Change from base Build 17: 0.0%
Covered Lines: 107
Relevant Lines: 108

💛 - Coveralls

@bupy7 bupy7 merged commit 63b83e9 into bupy7:master Jul 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.074%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.