New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPAN Pull Request Challenge 2015 #1

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@quicoju

quicoju commented Feb 26, 2015

Hi Burak,

This is a small contribution for the CPAN Pull Request challenge.

The overall changes consist of adding new tests to the test suite
in order to increase the score reported by `Devel::Cover'. Also
fixed a couple of minor typos in the documentation. Finally made
some minor changes in two of lib files for things that came up
while writing the new tests.

I named the new file `02-securityimage.t' because I wasn't sure
what the convention was, but please feel free to only take the
changes that you consider that might better serve this cool
package.

By the way, I didn't change the `VERSION' of the package, I thought
that you might want to wait until more changes added to the
package before upgrading the version.

Here's a brief summary of the changes per file:

  1. MANIFEST
    • Added the new file `02-securityimage.t'.
  2. lib/GD/SecurityImage.pm
    • Removed test for text_location' option, this seems to be replaced by theinfo_text' method.
    • Test that angle falls within the [-360,360] range.
    • Fixed 2 minor typos in the documentation.
  3. lib/GD/SecurityImage/GD.pm
    • `place_gd()' added default values to $black and $white.
  4. t/02-securityimage.t
    • Added a number of tests for the library API. Mostly tests when passing invalid arguments, or testing various angle values, etc.
  5. t/03-info_text.t
    • Defined test plan number
  6. t/04-backend.t
    • Added 2 more tests.
      1. At least 2 core backends come with the distribution.
      2. Test what happens when trying to import undefined backend.
  7. t/05-version.t
  • Added 4 new tests for the version testing methods.
  1. t/06-version_magick.t
  • Added 7 new tests basically to test different valid and invalid version numbers
  1. t/98-gd.t
    • Added tests for the blank style, also added test for different positioning of the info_text
  2. t/99-magick.t
    • Added tests for the blank style, also added test for different positioning of the info_text
  3. t/lib/Test/GDSI.pm
    • Added subs for creating `SecurityImage' objects using the blank style
CPAN Pull Request Challenge 2015
*  Overall description of the changes
   The overall changes consist of adding new tests to the test suite
   in order to increase the score reported by `Devel::Cover'. Also
   fixed a couple of minor typos in the documentation. Finally made
   some minor changes in two of lib files for things that came up
   while writing the new tests.

   I named the new file `02-securityimage.t' because I wasn't sure
   what the convention was, but please feel free to only take the
   changes that you consider that might better serve this cool
   package.

   By the way, I didn't change the `VERSION' of the package, I thought
   that you might want to wait until more changes added to the
   package before upgrading the version.

* Summary of changes
** MANIFEST
   - Added the new file `02-securityimage.t'.
** lib/GD/SecurityImage.pm
   - Removed test for `text_location' option, this seems to be
     replaced by the `info_text' method.
   - Test that angle falls within the [-360,360] range.
   - Fixed 2 minor typos in the documentation.
** lib/GD/SecurityImage/GD.pm
   - `place_gd()' added default values to $black and $white.
** t/02-securityimage.t
   - Added a number of tests for the library API. Mostly tests when
     passing invalid arguments, or testing various angle values, etc.
** t/03-info_text.t
   - Defined test plan number
** t/04-backend.t
   - Added 2 more tests.
     1. At least 2 core backends come with the distribution.
     2. Test what happens when trying to import undefined backend.
** t/05-version.t
   - Added 4 new tests for the version testing methods.
** t/06-version_magick.t
   - Added 7 new tests basically to test different valid and invalid
     version numbers
** t/98-gd.t
   - Added tests for the blank style, also added test for different
     positioning of the info_text
** t/99-magick.t
   - Added tests for the blank style, also added test for different
     positioning of the info_text
** t/lib/Test/GDSI.pm
   - Added subs for creating `SecurityImage' objects using the blank
     style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment