Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON serializer is fetched from Application env #12

Merged
merged 1 commit into from Jan 20, 2019

Conversation

Projects
None yet
2 participants
@arathunku
Copy link
Contributor

commented Jan 14, 2019

in response to #11 (comment)

Since this is a compile-time option, I didn't try to write tests for it. Should I add them and try to force recompile the module while running the tests? That might break some of the tests running concurrently, suggestions appreciated.

@buren

This comment has been minimized.

Copy link
Owner

commented Jan 15, 2019

I'm fine not having tests for that. Easy enough to test manually, should we later add more behavior like that it might be worth it.

Thank you 👍

@arathunku

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2019

I've resolved conflicts with the master branch.

Thank you for the library!

@buren buren merged commit 51d77a4 into buren:master Jan 20, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@buren

This comment has been minimized.

Copy link
Owner

commented Jan 20, 2019

@arathunku thank you 👍

@buren

This comment has been minimized.

Copy link
Owner

commented Jan 26, 2019

@arathunku just published v0.4.0 to hex.pm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.