Permalink
Browse files

[chromium] Clean up dependencies in ScrollbarLayerChromiumTest

https://bugs.webkit.org/show_bug.cgi?id=96052

Patch by James Robinson <jamesr@chromium.org> on 2012-09-07
Reviewed by Adrienne Walker.

Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
*) WebScrollbarImpl.h is #included, but not use
*) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if
    WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.

* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information...
1 parent 3c74c00 commit bbbd06c967cf05a0dbb099ef5663f52e08038e68 commit-queue committed Sep 7, 2012
Showing with 17 additions and 3 deletions.
  1. +15 −0 Source/WebKit/chromium/ChangeLog
  2. +2 −3 Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp
View
15 Source/WebKit/chromium/ChangeLog
@@ -1,3 +1,18 @@
+2012-09-07 James Robinson <jamesr@chromium.org>
+
+ [chromium] Clean up dependencies in ScrollbarLayerChromiumTest
+ https://bugs.webkit.org/show_bug.cgi?id=96052
+
+ Reviewed by Adrienne Walker.
+
+ Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
+ *) WebScrollbarImpl.h is #included, but not use
+ *) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if
+ WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.
+
+ * tests/ScrollbarLayerChromiumTest.cpp:
+ (WebCore::TEST):
+
2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
AX: ARIA spin button should support range value attributes
View
5 Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp
@@ -31,7 +31,6 @@
#include "CCSingleThreadProxy.h"
#include "FakeWebScrollbarThemeGeometry.h"
#include "TreeSynchronizer.h"
-#include "WebScrollbarImpl.h"
#include <gtest/gtest.h>
#include <public/WebScrollbar.h>
#include <public/WebScrollbarThemeGeometry.h>
@@ -68,7 +67,7 @@ TEST(ScrollbarLayerChromiumTest, resolveScrollLayerPointer)
{
DebugScopedSetImplThread impl;
- WebKit::WebScrollbarThemePainter painter(0, 0);
+ WebKit::WebScrollbarThemePainter painter;
{
OwnPtr<WebKit::WebScrollbar> scrollbar(FakeWebScrollbar::create());
@@ -109,7 +108,7 @@ TEST(ScrollbarLayerChromiumTest, scrollOffsetSynchronization)
{
DebugScopedSetImplThread impl;
- WebKit::WebScrollbarThemePainter painter(0, 0);
+ WebKit::WebScrollbarThemePainter painter;
OwnPtr<WebKit::WebScrollbar> scrollbar(FakeWebScrollbar::create());
RefPtr<LayerChromium> layerTreeRoot = LayerChromium::create();

0 comments on commit bbbd06c

Please sign in to comment.