Permalink
Browse files

[EFL] Keep placeholder text visible until first input from user.

https://bugs.webkit.org/show_bug.cgi?id=95851

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-06
Reviewed by Gyuyoung Kim.

Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
Therefore, this patch enabled it.

* platform/efl/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::shouldShowPlaceholderWhenFocused):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information...
1 parent 582154f commit d400626e68c1efb54fdf76b634e8299839101ac5 commit-queue committed Sep 6, 2012
Showing with 14 additions and 0 deletions.
  1. +13 −0 Source/WebCore/ChangeLog
  2. +1 −0 Source/WebCore/platform/efl/RenderThemeEfl.h
View
13 Source/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2012-09-06 Kangil Han <kangil.han@samsung.com>
+
+ [EFL] Keep placeholder text visible until first input from user.
+ https://bugs.webkit.org/show_bug.cgi?id=95851
+
+ Reviewed by Gyuyoung Kim.
+
+ Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
+ Therefore, this patch enabled it.
+
+ * platform/efl/RenderThemeEfl.h:
+ (WebCore::RenderThemeEfl::shouldShowPlaceholderWhenFocused):
+
2012-09-06 Elliott Sprehn <esprehn@chromium.org>
Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive
View
1 Source/WebCore/platform/efl/RenderThemeEfl.h
@@ -205,6 +205,7 @@ class RenderThemeEfl : public RenderTheme {
virtual bool paintMediaVolumeSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);
virtual bool paintMediaCurrentTime(RenderObject*, const PaintInfo&, const IntRect&);
#endif
+ virtual bool shouldShowPlaceholderWhenFocused() const OVERRIDE { return true; }
void setThemePath(const String&);
String themePath() { return m_themePath; }

0 comments on commit d400626

Please sign in to comment.