Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #99 - Let external user to decide the option handle_failures #115

Merged
merged 1 commit into from Apr 18, 2019
Merged

Fix #99 - Let external user to decide the option handle_failures #115

merged 1 commit into from Apr 18, 2019

Conversation

johnklee
Copy link

This PR is a candidate solution to solve issue #99 which is about exception caused by python-readability owing to invalid process on IPv6 address. The key idea is to let external user of python-readability to setup option handle_failures='discard' (which currently is invisible to external user) to get around issue #99.

@buriy buriy merged commit a4ac1c7 into buriy:master Apr 18, 2019
@johnklee johnklee deleted the Issue99 branch April 18, 2019 23:10
@johnklee
Copy link
Author

Hi @buriy
Many thanks for your time and great help in review this PR. I tried to update package readability-lxml

$ pip install --upgrade readability-lxml
Requirement already up-to-date: readability-lxml in ./env/lib/python3.6/site-packages (0.7)

It seems that the pypi has not been updated yet. Can you help to confirm it?
Many thanks for this great repo and your help again.

@buriy
Copy link
Owner

buriy commented Apr 19, 2019

Yes, I sometimes check the tests and publish it.
But you can also do pip install from github repo.

@johnklee
Copy link
Author

Hi @buriy
Sorry to bother you again. I have been checking pypi for a few days. Currently we adopted the temporary solution you suggest to install from github repo locally which is ok for testing. However, our pipeline will do installation each time during deployment by pip install -r requirements.txt. So it will be helpful to have an updated version in pypi to avoid subtle mistakes which may lead to unexpected bug in the pipeline. So is it possible to know when will you have new release in pypi? So we can update the requirements.txt as well to reflect the change?

Many thanks!

@buriy
Copy link
Owner

buriy commented Apr 22, 2019

Ok, I'll publish it this week, ASAP, and will I'll let you know.

@johnklee
Copy link
Author

Hi @buriy
Any update for the next version of readability-lxml (currently, is still 0.7)? Sorry for the bothering and thanks in advance for the help.

@buriy
Copy link
Owner

buriy commented Apr 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants