New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 for JavaScript assets #295

Closed
atodorov opened this Issue Aug 6, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@atodorov
Contributor

atodorov commented Aug 6, 2018

I am using the 6.1 version that you published on Friday. I get 404 for the following files:

[06/Aug/2018 07:51:06] "GET /static/report_builder/styles.bundle.css HTTP/1.1" 404 1720
[06/Aug/2018 07:51:06] "GET /static/report_builder/inline.bundle.js HTTP/1.1" 404 1717
[06/Aug/2018 07:51:06] "GET /static/report_builder/polyfills.bundle.js HTTP/1.1" 404 1726
[06/Aug/2018 07:51:06] "GET /static/report_builder/main.bundle.js HTTP/1.1" 404 1711
[06/Aug/2018 07:51:06] "GET /static/report_builder/main.bundle.js HTTP/1.1" 404 1711
[06/Aug/2018 07:51:06] "GET /static/report_builder/styles.bundle.css HTTP/1.1" 404 1720

and they are not to be found in the source. If this is a quick fix can you patch it ASAP ?

@bufke

This comment has been minimized.

Show comment
Hide comment
@bufke

bufke Aug 6, 2018

Member

There was a mistake made in releasing 6.2.0. Fixed in 6.2.1. Thanks.

Member

bufke commented Aug 6, 2018

There was a mistake made in releasing 6.2.0. Fixed in 6.2.1. Thanks.

@bufke bufke closed this Aug 6, 2018

@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Aug 6, 2018

Contributor

I've updated to django-report-builder==6.2.1 and I still see the same issue.

Contributor

atodorov commented Aug 6, 2018

I've updated to django-report-builder==6.2.1 and I still see the same issue.

@bufke

This comment has been minimized.

Show comment
Hide comment
@bufke

bufke Aug 6, 2018

Member

Hmm yes, not sure what's going on.

Member

bufke commented Aug 6, 2018

Hmm yes, not sure what's going on.

@bufke

This comment has been minimized.

Show comment
Hide comment
@bufke

bufke Aug 6, 2018

Member

Try 6.2.2. Seems like the file names changed at some point. Guessing a change in angular-cli.

Member

bufke commented Aug 6, 2018

Try 6.2.2. Seems like the file names changed at some point. Guessing a change in angular-cli.

@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Aug 6, 2018

Contributor

6.2.2 seems to work but maybe you should add some tests for these files.

Contributor

atodorov commented Aug 6, 2018

6.2.2 seems to work but maybe you should add some tests for these files.

@bufke

This comment has been minimized.

Show comment
Hide comment
@bufke

bufke Aug 6, 2018

Member

Feel free to contribute any ideas - unfortunately this type of issue is hard to test as only an end to end test could possibly catch it. Furthermore we would need to build assets on CI and then run the test. I think it's very doable but I do not have time for it. If you wanted to take on I think it would look like:

  • New build step in gitlab CI to build static assets
  • New step to test django app with static assets, (cheap way - sanity check assets exists, better way actually run a headless browser and do a sanity check that the frontend is working with the backend)
  • New deploy step that would include authentication to pypi and submit the finished build - perhaps based on tags. Currently builds are done manually outside of CI which is of course error prone.

Let me know if you think you can help! Thanks.

Member

bufke commented Aug 6, 2018

Feel free to contribute any ideas - unfortunately this type of issue is hard to test as only an end to end test could possibly catch it. Furthermore we would need to build assets on CI and then run the test. I think it's very doable but I do not have time for it. If you wanted to take on I think it would look like:

  • New build step in gitlab CI to build static assets
  • New step to test django app with static assets, (cheap way - sanity check assets exists, better way actually run a headless browser and do a sanity check that the frontend is working with the backend)
  • New deploy step that would include authentication to pypi and submit the finished build - perhaps based on tags. Currently builds are done manually outside of CI which is of course error prone.

Let me know if you think you can help! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment