Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include base template #29

Closed
smcoll opened this issue Sep 23, 2014 · 4 comments
Closed

include base template #29

smcoll opened this issue Sep 23, 2014 · 4 comments

Comments

@smcoll
Copy link
Contributor

smcoll commented Sep 23, 2014

A base template could be included that the other templates inherit from. This way, a user could override the base template without having to necessarily override the other four templates, when integrating with their markup. i'm happy to provide a pull request for this; just let me know if there are any preferences/conventions to consider.

@bufke
Copy link
Member

bufke commented Sep 26, 2014

I think that makes sense. We could include a little documentation on how to extend it too.

@bufke
Copy link
Member

bufke commented Sep 27, 2014

@BrendanBerkley do you think we could give this a bootstrap friendly base template? And then not override it in our other projects. It would have to work fine without bootstrap too. Of course people could just override or extend base is they wanted to.

@BrendanBerkley
Copy link

@bufke All things are possible with enough time! Let me know when would be a good time to work on this.

@bufke
Copy link
Member

bufke commented Nov 18, 2014

@smcoll if you are still interested I think it's safe to say we don't have time for this ourselves but we would review a pull request. I can test your implementation against my own customizations and make sure it's easy for people to implement. I've done this before but I'd love you input on how to make it as easy as possible for people.

https://github.com/burke-software/django-report-builder/blob/master/report_builder/templates/report_builder/base.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants