New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for images from the web in taxon/characters. #18

Merged
merged 1 commit into from May 14, 2018

Conversation

Projects
None yet
2 participants
@jflheureux
Copy link
Contributor

jflheureux commented May 13, 2018

Pull request for #17.

In the Excel file media sheet, you can now specify any HTTP/HTTPS URL in the URI column if you specify "image-web" in the Type column. This works for both taxon images and character images.

I was not able to minify the debug JavaScript files as there are no task runner nor bundling tool referenced in the repository. There are no instructions about that either in the coders documentation PDF file. I noticed you have not commit the minified files for months. I recommend using npm with a package.json file in the repository. You could have a npm build task that would minify the files with gulp and a minification plugin in an output directory that would be ignored by git. I could help you with that setup if you would like.

@burkmarr burkmarr merged commit 40f77ac into burkmarr:master May 14, 2018

@burkmarr

This comment has been minimized.

Copy link
Owner

burkmarr commented May 14, 2018

Great - thanks Jean-François - I've merged the pull request. I will document this before the next release (for knowledge-base developers).

Much of what you say about the minified files tests my limited experience of this kind of development. As far as the uncommitted minified files are concerned, I think that this was because the files in question were not being dynamically updated as I thought that they were. I am using VS2017 (community) and the 'Bundler & Minifier' extension. This worked like a charm in VS2015, dynamically updating the minified file whenever I saved a change to the source file, but it seems I'm having a few issues in VS2017.

Is the workflow you describe an alternative to using the VS2017 bundler extension?

@jflheureux

This comment has been minimized.

Copy link
Contributor

jflheureux commented May 18, 2018

Thank you for the merge.

Yes, the workflow I describe is agnostic to the code editor each collaborator is using. I am using Visual Studio Code for web development like this. It is much lighter than the full Visual Studio.

I have implemented minification using a gulp script in one of my branch. See this commit for an example of the changes needed: jflheureux@0799383

In general, you never commit the minified files as they are the result of a transformation (build). The only place minified files should be is in the releases. You only commit the source files.

In my case, I minify in the /dist folder. npm is a package manager with a library of thousands of package. I use it with the package.json file to install gulp and a few gulp tasks. Gulp is a task runner with multiple extensions. I use it to define a minify task that takes all the source JavaScript files, minify them, rename them, and save them in the /dist folder.

New contributors of my branch have to install the npm packages to start working. This command line is all they need:

npm install
npm install -g gulp

It will install gulp and its extensions in the local /node_modules folder. It will as well install gulp globally on their system.

Then, when a contributor wants to minify the source code of the project, he has one command line to run:

gulp minify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment