Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./run-checks.sh all report 'error: useless use of format!' when compiler burn-train #940

Closed
meteor-lsw opened this issue Nov 9, 2023 · 5 comments

Comments

@meteor-lsw
Copy link
Contributor

image

Compiling onnx-tests v0.11.0 (/home/lws/projects/burn/burn-import/onnx-tests)
Checking burn-tch v0.11.0 (/home/lws/projects/burn/burn-tch)
Checking burn-train v0.11.0 (/home/lws/projects/burn/burn-train)
error: useless use of format!
--> burn-train/src/renderer/tui/progress.rs:193:9
|
193 | format!("1 day")
| ^^^^^^^^^^^^^^^^ help: consider using .to_string(): "1 day".to_string()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: -D clippy::useless-format implied by -D warnings

error: useless use of format!
--> burn-train/src/renderer/tui/progress.rs:197:9
|
197 | format!("1 hour")
| ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): "1 hour".to_string()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

error: useless use of format!
--> burn-train/src/renderer/tui/progress.rs:201:9
|
201 | format!("1 min")
| ^^^^^^^^^^^^^^^^ help: consider using .to_string(): "1 min".to_string()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

error: useless use of format!
--> burn-train/src/renderer/tui/progress.rs:205:9
|
205 | format!("1 sec")
| ^^^^^^^^^^^^^^^^ help: consider using .to_string(): "1 sec".to_string()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

error: could not compile burn-train (lib) due to 4 previous errors

@nathanielsimard
Copy link
Member

What is your version of Rust?

@meteor-lsw
Copy link
Contributor Author

I am using current stable rust(1.73)

@meteor-lsw
Copy link
Contributor Author

image

@meteor-lsw
Copy link
Contributor Author

Do you suggest that I submit a small PR for this issue to be fixed? If you do, I would be happy to use this small issue as a starting point to try to contribute.

@meteor-lsw
Copy link
Contributor Author

meteor-lsw commented Nov 11, 2023

I found that this problem has been fixed in the latest code, so we can close this isue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants