add more algorithms for CHAOS #1
Merged
Conversation
|
This code looks great! I look forward to merging it as my first pull request! |
|
[ed] went ahead and added logic for 1d binary cell-aut. output looks reasonable, though it's a sort of weird and arbitrary interpretation: the cell states are bits in an 8b value; might be better to just return the sum of bits. |
|
Code looks good and runs fine. I'll start the work on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
you can merge this if you want, but haven't really done serious testing of the numerical output.
(that said, the algos themselves are simple and i've used them many times - output looks 'pretty close' so i wouldn't suspect anything is too far off.)
multiple algorithms to the CHAOS operator
as discussed on lines https://llllllll.co/t/teletype-chaos/9785/35
so far i have only tested in the TT simulator. i would like to do a more thorough check that numerical behavior is basically as expected.
i took the liberty of arbitrarily scaling the parameter input to [0, 10000], since this will have different meanings for different algos. state/output is still in [-10000, 10000]; some algos may have only unipolar output depending on input.
celullar automata algo is a special case, since the state and parameters are both relatively small integers by nature. they are left unscaled.
TODO
chaos_scale_valuesshould be called on operator init (i'm not sure where that happens) and whenever the algorithm is changed.