Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Out Same wrong calculation amount #543

Closed
llybin opened this issue Jun 20, 2019 · 2 comments

Comments

@llybin
Copy link
Contributor

commented Jun 20, 2019

Total amount in phoenix: 2.0147 BURST. But in real he send 4.0294 + 0.0147 BURST. Notification showed: You sent: 4.0441 BURST

image

This transaction: http://explorer.testnet.burst.devtrue.net/tx/6336122564853562297

image

@llybin llybin added the bug label Jun 20, 2019

@ohager

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

WOW! this is critical

@ohager ohager added the priority label Jun 20, 2019

ohager added a commit that referenced this issue Jun 20, 2019

@ohager

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Will be fixed in next PR. jfyi: the problem was that BRS is already multiplying the amount internally, which I wasn't aware of. So, in case of same multi out one need to send the single value and the list of recipients, and not sending the already multiplied value. Nice and very important catch! Thank you so much

ohager added a commit that referenced this issue Jun 20, 2019

blankey1337 added a commit that referenced this issue Jun 21, 2019

fix send multiout same (#545)
* fixed #543

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.