Sean Busbey busbey

  • Joined on

Organizations

@camping
@busbey
busbey commented on pull request apache/incubator-nifi#25
@busbey

Sure, it's just much easier to scan through commits when the tickets are at the start, especially in an abbreviated git history.

busbey commented on pull request apache/incubator-nifi#25
@busbey

Looks like I was too slow. Thanks again Apiri.

busbey commented on pull request apache/incubator-nifi#25
@busbey

Hi Apiri! Thanks for the correction. Could you begin the commit message with NIFI-356 rather than at the end? e.g. "NIFI-356 Correct capability des…

busbey commented on pull request apache/incubator-nifi#24
@busbey

I'm used to just seeing the parent have a version. If NiFi as a community doesn't have any particular rationale for also including version numbers …

busbey commented on pull request apache/incubator-nifi#24
@busbey

this could be package-private. if we're leaving it public so that others can build their own Kite Processors on top of it, it should have some java…

busbey commented on pull request apache/incubator-nifi#24
@busbey

This is an LGPL dependency, so you can't include it. (ref asf license guidelines) There is a cleanroom reimplementation that is appropriately licen…

busbey commented on pull request apache/incubator-nifi#24
@busbey

make package-private

busbey commented on pull request apache/incubator-nifi#24
@busbey

needs a file-level license

busbey commented on pull request apache/incubator-nifi#24
@busbey

What happens if someone is using this version of the reader but drops in a later version of Kite? Can we make this a non-public class that isn't in…

busbey commented on pull request apache/incubator-nifi#24
@busbey

Should be an ASF license.

busbey commented on pull request apache/incubator-nifi#24
@busbey

What happens if someone is using this version of the reader but drops in a later version of Kite? Can we make this a non-public class that isn't in…

busbey commented on pull request apache/incubator-nifi#24
@busbey

needs a file level license

busbey commented on pull request apache/incubator-nifi#24
@busbey

should be an ASF license block.

busbey commented on pull request apache/incubator-nifi#24
@busbey

needs a file level license

busbey commented on pull request apache/incubator-nifi#24
@busbey

needs a file level license

busbey commented on pull request apache/incubator-nifi#24
@busbey

needs a file level license

busbey commented on pull request apache/incubator-nifi#24
@busbey

needs a file level license

busbey commented on pull request apache/incubator-nifi#24
@busbey

needs a file level license

busbey commented on pull request apache/incubator-nifi#24
@busbey

needs a file-level license

busbey commented on pull request apache/incubator-nifi#24
@busbey

this should probably be a reference to project.version or some other variable.

busbey commented on pull request apache/incubator-nifi#24
@busbey

apologies if this is a NiFi-ism, but shouldn't this version just come from the parent pom?

busbey commented on pull request apache/incubator-nifi#24
@busbey

version should be 0.0.2-incubating-SNAPSHOT now.