This repository has been archived by the owner. It is now read-only.

Implement solution #9

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
2 participants
@ElijahCA

Hi there! Implementation details have been added to the bottom of the readme. The app is deployed here. Please let me know if you have any questions!

@cdnbacon

This comment has been minimized.

Show comment Hide comment
@cdnbacon

cdnbacon Feb 19, 2014

Contributor

@ElijahCA I like what I see, but there's a pretty serious bug, repro is curl "http://127.0.0.1:3000/suggestions?q=M" or http://powerful-sierra-1219.herokuapp.com/suggestions?q=M

Can you fix it and then I'll start my review?

Contributor

cdnbacon commented Feb 19, 2014

@ElijahCA I like what I see, but there's a pretty serious bug, repro is curl "http://127.0.0.1:3000/suggestions?q=M" or http://powerful-sierra-1219.herokuapp.com/suggestions?q=M

Can you fix it and then I'll start my review?

@ElijahCA

This comment has been minimized.

Show comment Hide comment
@ElijahCA

ElijahCA Feb 19, 2014

@cdnbacon sorry about that. The bug should be fixed now. Let me know if you have any other problems!

@cdnbacon sorry about that. The bug should be fixed now. Let me know if you have any other problems!

@ElijahCA

This comment has been minimized.

Show comment Hide comment
@ElijahCA

ElijahCA Feb 19, 2014

Sorry to change the code under your feet, if you had started reviewing. I found a better solution to the bug you encountered, and have implemented it in 2fcc979.

Sorry to change the code under your feet, if you had started reviewing. I found a better solution to the bug you encountered, and have implemented it in 2fcc979.

@ElijahCA

This comment has been minimized.

Show comment Hide comment
@ElijahCA

ElijahCA Feb 20, 2014

Sorry for another update; I thought of a better solution to the bug that you encountered today, so I've implemented it here.

If I think of anything else that I want to improve before you take a look, I'll add it to the pull request. You're free to take a look whenever you get a chance -- I'll always leave the pull request in a reviewable state, and keep the deployed code on Heroku up to date.

Sorry for another update; I thought of a better solution to the bug that you encountered today, so I've implemented it here.

If I think of anything else that I want to improve before you take a look, I'll add it to the pull request. You're free to take a look whenever you get a chance -- I'll always leave the pull request in a reviewable state, and keep the deployed code on Heroku up to date.

@cdnbacon cdnbacon closed this Feb 25, 2014

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.