Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REMOVE] zend service manager from factories #42

Merged
merged 1 commit into from May 17, 2019

Conversation

Projects
None yet
2 participants
@Orkin
Copy link
Contributor

commented Apr 3, 2019

Update interface to PsrContainerInterface to allow to use any other service manager who implement the PSR 11

@basz

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Nice. I’ll make those tests pass as it is an issue with my code styling lib.

@Orkin

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Yes, I think you can upgrade some minimal dependencies versions and it could be great to remove the use of PluginManager (it work like that but we can’t remove the dependecy with the zend-servicemanager). As expressive allow many of containers it is not usefull 😊

@basz

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Thinking. Not sure if I want to remove that dependency as I use https://github.com/bushbaby/BsbFlysystem/blob/master/README.md#advanced-usage in my applications...

@Orkin

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

@basz ok and what about just enabling this feature only with containers that's support it ? And make Zend ServiceManager as suggested dependencies like other container ?

I think it can be good to make this package interoperable.

I saw that de Symfony DI support also the shared option : https://symfony.com/doc/current/service_container/shared.html

@basz

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Hi, made some progress with my PR against this one. Tests are successful. I dropped support for php70 and am considering to drop php71 as well. But then I thought it's nicer to involve you in such a decision. Overall I don't use either of those versions so I'm am ok with a major release drop support for those versions. How about you?

@basz basz merged commit c9d35ed into bushbaby:master May 17, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer 1 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.