From fca05c26af2f0976924ab9c6f4240383a6dd3813 Mon Sep 17 00:00:00 2001 From: Christian Johansen Date: Tue, 10 Jul 2012 13:38:35 +0200 Subject: [PATCH] Pass browser runner results to callback - Avoid incorrect exit code of 1 for successful tests --- lib/runners/browser.js | 4 ++-- package.json | 2 +- test/runners/browser-test.js | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/runners/browser.js b/lib/runners/browser.js index c785ea3..2bc767f 100644 --- a/lib/runners/browser.js +++ b/lib/runners/browser.js @@ -243,9 +243,9 @@ var testRun = { return callback(hookError); } - runner.on("suite:end", function () { + runner.on("suite:end", function (results) { this.endSession(session); - callback(); + callback(null, results); }.bind(this)); }.bind(this)); }, diff --git a/package.json b/package.json index a7ec16b..a5468e2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "buster-test-cli", - "version": "0.6.1", + "version": "0.6.2", "description": "Cli tools for Buster.JS test runners", "homepage": "http://busterjs.org/docs/buster-test-cli", "author": { "name": "August Lilleaas and Christian Johansen" }, diff --git a/test/runners/browser-test.js b/test/runners/browser-test.js index c28c4a3..d46c991 100644 --- a/test/runners/browser-test.js +++ b/test/runners/browser-test.js @@ -705,9 +705,10 @@ buster.testCase("Browser runner", { var callback = this.spy(); this.run.runTests(this.session, callback); - this.remoteRunner.emit("suite:end"); + this.remoteRunner.emit("suite:end", { ok: true }); assert.calledOnce(callback); + assert.calledWith(callback, null, { ok: true }); }, "prints to stderr on unsuccesful session close":