This repository has been archived by the owner. It is now read-only.

IE8 compatibility: use replacement for Object.create(..) #120

Closed
meisl opened this Issue Mar 5, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@meisl
Member

meisl commented Mar 5, 2012

Setup:

  • WinXP Pro SP3 32bit, node 0.6.11 via .msi installer, npm is 1.1.1 (came with the .msi)
  • buster 0.4.5 installed via npm with a few hacks by hand to get it going:
  • alongside buster/: pre-built contextify (ATTENTION: needs some more, not to be used as-is)
  • watch-tree installed via npm into buster/node_modules (used by buster-autotest, missing from deps) - yet this is defunct on Win
    -simple browser tests (html-scaffold only) use the 0.4.5 buster-test.js and buster-test.css from busterjs.org

Problem:
IE8 doesn't support Object.create(..) which is used in buster-test.js line 2392 (simple browser test)

Workaround:
My workaround at the moment is to set Object.create to my own if it's undefined.
However, I'm pretty sure you guys already have a replacement in place somewhere, just not always using it.

p.s.: I'm fully aware that Windows support is a thing for the future - just trying to help a little with it.

@augustl

This comment has been minimized.

Member

augustl commented Mar 5, 2012

Thanks for the report!

Turns out this has been fixed, it's just not in npm yet. We have our own buster.create that we should use.

busterjs/buster-test@c1b3f97
busterjs/buster-test#3

@augustl augustl closed this Mar 5, 2012

@meisl

This comment has been minimized.

Member

meisl commented Mar 5, 2012

Great!
just a few minutes ago I added the similar #121 re Array.some(..) - guess it can be closed right away just like this one.

@rauhryan

This comment has been minimized.

rauhryan commented Mar 29, 2012

So... Have the download scripts on busterjs.org been updated?

I just downloaded them the other day and ran into this issue. Where can I get the updated buster-test.js?

@meisl

This comment has been minimized.

Member

meisl commented Mar 30, 2012

Hi Ryan, they've not been updated yet.
You can build them yourself, with the dev environment. But if you're on Windows, as I guess, that can be a bit of a challenge. From #146 I conclude that you tried, is that right?
To get you going I've built them from master, you can get them here. But plz note that this is not official, just until busterjs.org has been updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.