This repository has been archived by the owner. It is now read-only.

XML reporter doesn't show Uncaught errors #134

Closed
trodrigues opened this Issue Mar 15, 2012 · 5 comments

Comments

Projects
None yet
3 participants
@trodrigues
Contributor

trodrigues commented Mar 15, 2012

The XML reporter doesn't include uncaught errors (yellow ones on other reporters). It just completely ignores them.

@augustl

This comment has been minimized.

Member

augustl commented Mar 15, 2012

As discussed on IRC, we decided that this condition is satisfied in #81 - proper exit codes.

@augustl augustl closed this Mar 15, 2012

@cjohansen cjohansen reopened this Mar 15, 2012

@cjohansen

This comment has been minimized.

Member

cjohansen commented Mar 15, 2012

The discussion in IRC was about failed pre-conditions. Uncaught errors in the test run should definitely be part of the report.

@augustl

This comment has been minimized.

Member

augustl commented Mar 15, 2012

Whoopsies.

The dot reporter currently prints the yellow uncaught errors in between the dots, some characters gets overwritten by dots, etc. I guess this is because it prints to stderr? With this in mind, does it make sense that it's up to the individual reporters to print uncaught errors? Makes sense to me, since want to have reporter specific printing of it for xml, and since the current way it works with the dot reporter ends up looking odd.

@cjohansen

This comment has been minimized.

Member

cjohansen commented Mar 15, 2012

Yes, uncaught exceptions are just one of the messages the test runner emits, so it definitely belongs in reporters.

The dots reporter prints uncaught exceptions somewhat ugly on purpose... It's to have them printed as soon as possible. I guess we could fix it so it adds a line above the dots though. File an issue if you think it's important enough :)

@cjohansen

This comment has been minimized.

Member

cjohansen commented Apr 13, 2012

Fixed: busterjs/buster-test@11f4d04

Curiously, the dots reporter has also seen some improvement.

@cjohansen cjohansen closed this Apr 13, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.