This repository has been archived by the owner. It is now read-only.

Timeout should be counted as a failure? #196

Closed
rvagg opened this Issue Jun 17, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@rvagg

rvagg commented Jun 17, 2012

A string like the following gets printed in green to the console:

1 test case, 1 test, 26 assertions, 0 failures, 0 errors, 1 timeout

because console#success(stats) doesn't count a timeout as a failure. I would have thought it should be, or perhaps there's a philosophical issue here I'm missing?

@augustl

This comment has been minimized.

Member

augustl commented Jun 29, 2012

As far as I can recall, this isn't a concious desicion. A timeout is indeed an error imo.

@cjohansen

This comment has been minimized.

Member

cjohansen commented Jul 5, 2012

That's a (stupid) bug, resulting from a lazy ass test :'(

busterjs/buster-test@30b12d9

@cjohansen cjohansen closed this Jul 5, 2012

@ghost ghost assigned cjohansen Jul 5, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.